QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-10 11:55:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improving Presto error message in explore/dashboard (#2633)

Browse Source 
* Improving Presto error message in explore/dashboard

* lint
This commit is contained in:
Maxime Beauchemin
2017-04-18 12:30:17 -07:00
committed by GitHub
parent ac51a30f98
commit cb3384b3b2
3 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset/assets/javascripts/explorev2/components/DisplayQueryButton.jsx
View File

@@ -57,7 +57,7 @@ export default class DisplayQueryButton extends React.PureComponent {
});
}
beforeOpen() {
if (this.props.chartStatus === 'loading' || this.props.chartStatus === null) {
if (['loading', null].indexOf(this.props.chartStatus) >= 0 || !this.props.queryResponse) {
this.fetchQuery();
} else {
this.setStateFromQueryResponse();
@@ -72,11 +72,13 @@ export default class DisplayQueryButton extends React.PureComponent {
/>);
} else if (this.state.error) {
return <pre>{this.state.error}</pre>;
} else if (this.state.query) {
return (
<SyntaxHighlighter language={this.state.language} style={github}>
{this.state.query}
</SyntaxHighlighter>);
}
return (
<SyntaxHighlighter language={this.state.language} style={github}>
{this.state.query}
</SyntaxHighlighter>);
return null;
}
render() {
return (