QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

updating adhoc metric filtering (#5105)

Browse Source
This commit is contained in:
Gabe Lyons
2018-05-31 23:34:48 -07:00
committed by John Bodley
parent 556ef44fac
commit cc0942ac98
3 changed files with 20 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
superset/assets/spec/javascripts/explore/components/MetricsControl_spec.jsx
View File

@@ -211,8 +211,8 @@ describe('MetricsControl', () => {
expect(!!wrapper.instance().selectFilterOption(
{
metric_name: 'a_metric',
optionName: 'a_metric',
metric_name: 'avg__metric',
optionName: 'avg__metric',
expression: 'AVG(metric)',
},
'a',
@@ -238,14 +238,27 @@ describe('MetricsControl', () => {
expect(!!wrapper.instance().selectFilterOption(
{
metric_name: 'a_metric',
optionName: 'a_metric',
metric_name: 'avg__metric',
optionName: 'avg__metric',
expression: 'AVG(metric)',
},
'a',
)).to.be.false;
});
it('includes custom made simple saved metrics', () => {
const { wrapper } = setup();
expect(!!wrapper.instance().selectFilterOption(
{
metric_name: 'my_fancy_sum_metric',
optionName: 'my_fancy_sum_metric',
expression: 'SUM(value)',
},
'sum',
)).to.be.true;
});
it('excludes auto generated metrics', () => {
const { wrapper } = setup();