fix: import database engine validation (#24697)

(cherry picked from commit cb9b865a53)
This commit is contained in:
Daniel Vaz Gaspar
2023-07-20 13:08:07 +01:00
committed by Michael S. Molina
parent 1625fe4104
commit cc7983cd4a
4 changed files with 59 additions and 10 deletions

View File

@@ -42,7 +42,7 @@ def test_import_database(mocker: MockFixture, session: Session) -> None:
config = copy.deepcopy(database_config)
database = import_database(session, config)
assert database.database_name == "imported_database"
assert database.sqlalchemy_uri == "sqlite:///test.db"
assert database.sqlalchemy_uri == "someengine://user:pass@host1"
assert database.cache_timeout is None
assert database.expose_in_sqllab is True
assert database.allow_run_async is False
@@ -65,6 +65,32 @@ def test_import_database(mocker: MockFixture, session: Session) -> None:
assert database.allow_dml is False
def test_import_database_sqlite_invalid(mocker: MockFixture, session: Session) -> None:
"""
Test importing a database.
"""
from superset import app, security_manager
from superset.databases.commands.importers.v1.utils import import_database
from superset.models.core import Database
from tests.integration_tests.fixtures.importexport import database_config_sqlite
app.config["PREVENT_UNSAFE_DB_CONNECTIONS"] = True
mocker.patch.object(security_manager, "can_access", return_value=True)
engine = session.get_bind()
Database.metadata.create_all(engine) # pylint: disable=no-member
config = copy.deepcopy(database_config_sqlite)
with pytest.raises(ImportFailedError) as excinfo:
_ = import_database(session, config)
assert (
str(excinfo.value)
== "SQLiteDialect_pysqlite cannot be used as a data source for security reasons."
)
# restore app config
app.config["PREVENT_UNSAFE_DB_CONNECTIONS"] = True
def test_import_database_managed_externally(
mocker: MockFixture,
session: Session,