QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore (SIP-117): remove more sqlparse

Browse Source
This commit is contained in:
Beto Dealmeida
2024-11-22 12:04:19 -05:00
parent f8adaf66c1
commit cd3209a600
14 changed files with 56 additions and 122 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/integration_tests/db_engine_specs/base_engine_spec_tests.py
View File

@@ -30,7 +30,8 @@ from superset.db_engine_specs.base import (
from superset.db_engine_specs.mysql import MySQLEngineSpec
from superset.db_engine_specs.sqlite import SqliteEngineSpec
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.sql_parse import ParsedQuery, Table
from superset.sql.parse import SQLScript
from superset.sql_parse import Table
from superset.utils.database import get_example_database
from tests.integration_tests.db_engine_specs.base_tests import TestDbEngineSpec
from tests.integration_tests.test_app import app
@@ -312,7 +313,7 @@ class TestDbEngineSpecs(TestDbEngineSpec):
def test_is_readonly():
def is_readonly(sql: str) -> bool:
return BaseEngineSpec.is_readonly_query(ParsedQuery(sql))
return not SQLScript(sql, engine=BaseEngineSpec.engine).has_mutation()
assert is_readonly("SHOW LOCKS test EXTENDED")
assert not is_readonly("SET hivevar:desc='Legislators'")

5
tests/integration_tests/db_engine_specs/hive_tests.py
View File

@@ -23,7 +23,8 @@ from sqlalchemy.sql import select
from superset.db_engine_specs.hive import HiveEngineSpec, upload_to_s3
from superset.exceptions import SupersetException
from superset.sql_parse import ParsedQuery, Table
from superset.sql.parse import SQLScript
from superset.sql_parse import Table
from tests.integration_tests.test_app import app
@@ -224,7 +225,7 @@ def test_df_to_sql_if_exists_replace_with_schema(mock_upload_to_s3, mock_g):
def test_is_readonly():
def is_readonly(sql: str) -> bool:
return HiveEngineSpec.is_readonly_query(ParsedQuery(sql))
return not SQLScript(sql, engine=HiveEngineSpec.engine).has_mutation()
assert not is_readonly("UPDATE t1 SET col1 = NULL")
assert not is_readonly("INSERT OVERWRITE TABLE tabB SELECT a.Age FROM TableA")

5
tests/integration_tests/db_engine_specs/presto_tests.py
View File

@@ -25,7 +25,8 @@ from sqlalchemy.sql import select
from superset.db_engine_specs.presto import PrestoEngineSpec
from superset.errors import ErrorLevel, SupersetError, SupersetErrorType
from superset.sql_parse import ParsedQuery, Table
from superset.sql.parse import SQLScript
from superset.sql_parse import Table
from superset.utils.database import get_example_database
from tests.integration_tests.db_engine_specs.base_tests import TestDbEngineSpec
@@ -1174,7 +1175,7 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
def test_is_readonly():
def is_readonly(sql: str) -> bool:
return PrestoEngineSpec.is_readonly_query(ParsedQuery(sql))
return not SQLScript(sql, engine=PrestoEngineSpec.engine).has_mutation()
assert not is_readonly("SET hivevar:desc='Legislators'")
assert not is_readonly("UPDATE t1 SET col1 = NULL")