QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-26 03:24:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(explore): Don't discard controls with custom sql when changing datasource (#20934)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2022-10-19 15:29:38 +02:00
committed by GitHub
parent ec20c0104e
commit cddc361adc
22 changed files with 193 additions and 183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset-frontend/src/explore/components/controls/MetricControl/MetricDefinitionValue.jsx
View File

@@ -35,6 +35,7 @@ const propTypes = {
savedMetricsOptions: PropTypes.arrayOf(savedMetricType),
multi: PropTypes.bool,
datasource: PropTypes.object,
datasourceWarningMessage: PropTypes.string,
};
export default function MetricDefinitionValue({
@@ -50,6 +51,7 @@ export default function MetricDefinitionValue({
index,
type,
multi,
datasourceWarningMessage,
}) {
const getSavedMetricByName = metricName =>
savedMetrics.find(metric => metric.metric_name === metricName);
@@ -78,6 +80,7 @@ export default function MetricDefinitionValue({
savedMetric: savedMetric ?? {},
type,
multi,
datasourceWarningMessage,
};
return <AdhocMetricOption {...metricOptionProps} />;