QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-08 17:19:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(explore): Don't discard controls with custom sql when changing datasource (#20934)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2022-10-19 15:29:38 +02:00
committed by GitHub
parent ec20c0104e
commit cddc361adc
22 changed files with 193 additions and 183 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
superset-frontend/src/explore/controlUtils/getControlValuesCompatibleWithDatasource.ts
View File

@@ -21,9 +21,9 @@ import { ControlState, Dataset, Metric } from '@superset-ui/chart-controls';
import {
Column,
isAdhocMetricSimple,
isAdhocMetricSQL,
isSavedMetric,
isSimpleAdhocFilter,
isFreeFormAdhocFilter,
JsonValue,
SimpleAdhocFilter,
} from '@superset-ui/core';
@@ -72,7 +72,10 @@ const isControlValueCompatibleWithDatasource = (
column.column_name === (value as SimpleAdhocFilter).subject,
);
}
if (isFreeFormAdhocFilter(value)) return true;
if (isAdhocMetricSQL(value)) {
Object.assign(value, { datasourceWarning: true });
return true;
}
return false;
};