QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: Use dashboard name for screenshot download (#34988)

Browse Source
This commit is contained in:
Vitor Avila
2025-09-05 02:16:45 -03:00
committed by GitHub
parent 9424538bb1
commit ce74ae095d
5 changed files with 118 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
superset/dashboards/api.py
View File

@@ -113,6 +113,7 @@ from superset.tasks.thumbnails import (
from superset.tasks.utils import get_current_user
from superset.utils import json
from superset.utils.core import parse_boolean_string
from superset.utils.file import get_filename
from superset.utils.pdf import build_pdf_from_screenshots
from superset.utils.screenshots import (
DashboardScreenshot,
@@ -1204,6 +1205,10 @@ class DashboardRestApi(BaseSupersetModelRestApi):
image = cache_payload.get_image()
except ScreenshotImageNotAvailableException:
return self.response_404()
filename = get_filename(
dashboard.dashboard_title or "screenshot", dashboard.id, skip_id=True
)
if download_format == "pdf":
pdf_img = image.getvalue()
# Convert the screenshot to PDF
@@ -1212,13 +1217,18 @@ class DashboardRestApi(BaseSupersetModelRestApi):
return Response(
pdf_data,
mimetype="application/pdf",
headers={"Content-Disposition": "inline; filename=dashboard.pdf"},
headers={
"Content-Disposition": f'attachment; filename="{filename}.pdf"'
},
direct_passthrough=True,
)
if download_format == "png":
return Response(
FileWrapper(image),
mimetype="image/png",
headers={
"Content-Disposition": f'attachment; filename="{filename}.png"'
},
direct_passthrough=True,
)
return self.response_404()