QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

style: replace broken glyphs with font-awesome (#10123)

Browse Source 
Glyphicons stopped working recently, not sure why, but let's get rid of
them and double down on font-awesome that we use a lot more in the
codebase. There's only a few instances of glyphicons and they all are
broken ATM.

Also a few other minor style tweaks
This commit is contained in:
Maxime Beauchemin
2020-06-21 21:38:08 -07:00
committed by GitHub
parent e49ba8f03c
commit cf0f1d568d
8 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/src/explore/components/AdhocFilterEditPopover.jsx
View File

@@ -184,7 +184,7 @@ export default class AdhocFilterEditPopover extends React.Component {
</Button>
<i
onMouseDown={this.onDragDown}
className="glyphicon glyphicon-resize-full edit-popover-resize"
className="fa fa-expand edit-popover-resize text-muted"
/>
</div>
</Popover>

4
superset-frontend/src/explore/components/AdhocFilterOption.jsx
View File

@@ -112,7 +112,9 @@ export default class AdhocFilterOption extends React.PureComponent {
<Label className="option-label adhoc-option adhoc-filter-option">
{adhocFilter.getDefaultLabel()}
<i
className={`glyphicon glyphicon-triangle-right adhoc-label-arrow`}
className={`fa fa-caret-${
this.state.overlayShown ? 'left' : 'right'
} adhoc-label-arrow`}
/>
</Label>
</OverlayTrigger>

2
superset-frontend/src/explore/components/AdhocMetricEditPopover.jsx
View File

@@ -318,7 +318,7 @@ export default class AdhocMetricEditPopover extends React.Component {
</Button>
<i
onMouseDown={this.onDragDown}
className="glyphicon glyphicon-resize-full edit-popover-resize"
className="fa fa-expand edit-popover-resize text-muted"
/>
</div>
</Popover>

6
superset-frontend/src/explore/components/AdhocMetricOption.jsx
View File

@@ -53,7 +53,7 @@ export default class AdhocMetricOption extends React.PureComponent {
// once the overlay has been opened, the metric/filter will never be
// considered new again.
this.props.adhocMetric.isNew = false;
this.setState({ overlayShown: false });
this.setState({ overlayShown: true });
}
onOverlayExited() {
@@ -99,7 +99,9 @@ export default class AdhocMetricOption extends React.PureComponent {
<Label className="option-label adhoc-option">
{adhocMetric.label}
<i
className={`glyphicon glyphicon-triangle-right adhoc-label-arrow`}
className={`fa fa-caret-${
this.state.overlayShown ? 'left' : 'right'
} adhoc-label-arrow`}
/>
</Label>
</OverlayTrigger>

6
superset-frontend/src/explore/components/controls/DateFilterControl.jsx
View File

@@ -340,7 +340,7 @@ export default class DateFilterControl extends React.Component {
renderInput(props, key) {
return (
<FormGroup>
<InputGroup>
<InputGroup bsSize="small">
<FormControl
{...props}
type="text"
@@ -350,7 +350,7 @@ export default class DateFilterControl extends React.Component {
/>
<InputGroup.Button onClick={() => this.toggleCalendar(key)}>
<Button>
<Glyphicon glyph="calendar" style={{ padding: 3 }} />
<i className="fa fa-calendar" />
</Button>
</InputGroup.Button>
</InputGroup>
@@ -454,7 +454,7 @@ export default class DateFilterControl extends React.Component {
</div>
<div
style={{ width: '60px', marginTop: '-4px' }}
className="input-inline"
className="input-inline m-l-5 m-r-3"
>
<FormControl
bsSize="small"