QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 08:34:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: improve event logging for queries + refactor (#27943)

Browse Source 
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
This commit is contained in:
Maxime Beauchemin
2024-04-22 16:30:50 -07:00
committed by GitHub
parent 83fedcc9ea
commit cfc440c56c
14 changed files with 169 additions and 132 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/unit_tests/sql_lab_test.py
View File

@@ -38,6 +38,7 @@ def test_execute_sql_statement(mocker: MockerFixture, app: None) -> None:
database = query.database
database.allow_dml = False
database.apply_limit_to_sql.return_value = "SELECT 42 AS answer LIMIT 2"
database.mutate_sql_based_on_config.return_value = "SELECT 42 AS answer LIMIT 2"
db_engine_spec = database.db_engine_spec
db_engine_spec.is_select_query.return_value = True
db_engine_spec.fetch_data.return_value = [(42,)]
@@ -71,15 +72,16 @@ def test_execute_sql_statement_with_rls(
from superset.sql_lab import execute_sql_statement
sql_statement = "SELECT * FROM sales"
sql_statement_with_rls = f"{sql_statement} WHERE organization_id=42"
sql_statement_with_rls_and_limit = f"{sql_statement_with_rls} LIMIT 101"
query = mocker.MagicMock()
query.limit = 100
query.select_as_cta_used = False
database = query.database
database.allow_dml = False
database.apply_limit_to_sql.return_value = (
"SELECT * FROM sales WHERE organization_id=42 LIMIT 101"
)
database.apply_limit_to_sql.return_value = sql_statement_with_rls_and_limit
database.mutate_sql_based_on_config.return_value = sql_statement_with_rls_and_limit
db_engine_spec = database.db_engine_spec
db_engine_spec.is_select_query.return_value = True
db_engine_spec.fetch_data.return_value = [(42,)]