QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 15:44:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: cleaning out unused code from utils (#11076)

Browse Source 
* removing unused stuff (and some jquery) from utils.js

* linting
This commit is contained in:
Evan Rusackas
2020-09-27 20:08:05 -07:00
committed by GitHub
parent 7f1e4e441d
commit cff034e2cf
11 changed files with 19 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
superset-frontend/src/modules/utils.js
View File

@@ -17,41 +17,6 @@
* under the License.
*/
/* eslint camelcase: 0 */
import $ from 'jquery';
/**
* Sets the body and title content of a modal, and shows it. Assumes HTML for modal exists and that
* it handles closing (i.e., works with bootstrap)
*
* @param {object} options object of the form
* {
* title: {string},
* body: {string},
* modalSelector: {string, default: '.misc-modal' },
* titleSelector: {string, default: '.misc-modal .modal-title' },
* bodySelector: {string, default: '.misc-modal .modal-body' },
* }
*/
export function showModal(options) {
/* eslint no-param-reassign: 0 */
options.modalSelector = options.modalSelector || '.misc-modal';
options.titleSelector = options.titleSelector || '.misc-modal .modal-title';
options.bodySelector = options.bodySelector || '.misc-modal .modal-body';
$(options.titleSelector).html(options.title || '');
$(options.bodySelector).html(options.body || '');
$(options.modalSelector).modal('show');
}
export function formatSelectOptionsForRange(start, end) {
// outputs array of arrays
// formatSelectOptionsForRange(1, 5)
// returns [[1,1], [2,2], [3,3], [4,4], [5,5]]
const options = [];
for (let i = start; i <= end; i += 1) {
options.push([i, i.toString()]);
}
return options;
}
export function formatSelectOptions(options) {
return options.map(opt => [opt, opt.toString()]);