QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-27 03:55:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: store form_data as dict during viz type migration (#36680)

Browse Source
This commit is contained in:
Vitor Avila
2025-12-16 18:32:29 -03:00
committed by GitHub
parent d0361cb881
commit d14f502126
3 changed files with 150 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
tests/unit_tests/charts/commands/importers/v1/utils_test.py
View File

@@ -171,3 +171,44 @@ def test_migrate_pivot_table() -> None:
"version": "1.0.0",
"dataset_uuid": "a18b9cb0-b8d3-42ed-bd33-0f0fadbf0f6d",
}
def test_migrate_chart_query_context_form_data_is_dict() -> None:
"""
Test that form_data in query_context remains a dict after migration.
"""
chart_config = {
"slice_name": "Pivot Table with Query Context",
"description": None,
"certified_by": None,
"certification_details": None,
"viz_type": "pivot_table",
"params": json.dumps(
{
"columns": ["state"],
"groupby": ["name"],
"metrics": ["count"],
"viz_type": "pivot_table",
}
),
"query_context": json.dumps(
{
"form_data": {
"slice_id": 123,
"viz_type": "pivot_table",
"columns": ["state"],
},
"queries": [{"columns": ["state"]}],
}
),
"cache_timeout": None,
"uuid": "a18b9cb0-b8d3-42ed-bd33-0f0fadbf0f6d",
"version": "1.0.0",
"dataset_uuid": "ffd15af2-2188-425c-b6b4-df28aac45872",
}
new_config = migrate_chart(chart_config)
query_context = json.loads(new_config["query_context"])
assert query_context["form_data"]["viz_type"] == "pivot_table_v2"
assert isinstance(query_context["form_data"], dict)