QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 11:25:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix chart annotation source type showing perpetual loading when re-selecting the same value. (#10036)

Browse Source 
Remove accidental console.log used during testing.

Co-authored-by: Natalie Ruhe <natalie@preset.io>
This commit is contained in:
Natalie Ruhe
2020-06-10 16:17:56 -07:00
committed by GitHub
parent 36627af916
commit d1588c7658
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
superset-frontend/src/explore/components/controls/AnnotationLayer.jsx
View File

@@ -240,12 +240,16 @@ export default class AnnotationLayer extends React.PureComponent {
}
handleAnnotationSourceType(sourceType) {
this.setState({
sourceType,
isLoadingOptions: true,
validationErrors: {},
value: null,
});
const { sourceType: prevSourceType } = this.state;
if (prevSourceType !== sourceType) {
this.setState({
sourceType,
isLoadingOptions: true,
validationErrors: {},
value: null,
});
}
}
handleValue(value) {