QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(sqllab): throw errors of commented out query (#23378)

Browse Source
This commit is contained in:
JUST.in DO IT
2023-03-23 16:06:22 -07:00
committed by GitHub
parent 8f846b7ad0
commit d1947f7354
3 changed files with 34 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
superset-frontend/src/SqlLab/actions/sqlLab.js
View File

@@ -353,6 +353,14 @@ export function fetchQueryResults(query, displayLimit) {
};
}
export function cleanSqlComments(sql) {
if (!sql) return '';
// it sanitizes the following comment block groups
// group 1 -> /* */
// group 2 -> --
return sql.replace(/(--.*?$|\/\*[\s\S]*?\*\/)\n?/gm, '\n').trim();
}
export function runQuery(query) {
return function (dispatch) {
dispatch(startQuery(query));
@@ -362,7 +370,7 @@ export function runQuery(query) {
json: true,
runAsync: query.runAsync,
schema: query.schema,
sql: query.sql,
sql: cleanSqlComments(query.sql),
sql_editor_id: query.sqlEditorId,
tab: query.tab,
tmp_table_name: query.tempTable,