QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(explore): Prevent infinite rerenders when editing dataset (#22219)

Browse Source
This commit is contained in:
Kamil Gabryjelski
2022-11-25 16:00:21 +01:00
committed by GitHub
parent 9578a443ef
commit d1e576cbd1
1 changed files with 19 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
superset-frontend/src/explore/components/ControlPanelsContainer.tsx
View File

@@ -266,6 +266,7 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
const prevState = usePrevious(props.exploreState);
const prevDatasource = usePrevious(props.exploreState.datasource);
const prevChartStatus = usePrevious(props.chart.chartStatus);
const [showDatasourceAlert, setShowDatasourceAlert] = useState(false);
@@ -277,40 +278,45 @@ export const ControlPanelsContainer = (props: ControlPanelsContainerProps) => {
>(state => state.explore.controlsTransferred);
useEffect(() => {
let shouldUpdateControls = false;
const removeDatasourceWarningFromControl = (
value: JsonValue | undefined,
) => {
if (
typeof value === 'object' &&
isDefined(value) &&
'datasourceWarning' in value
'datasourceWarning' in value &&
value.datasourceWarning === true
) {
shouldUpdateControls = true;
return { ...value, datasourceWarning: false };
}
return value;
};
if (props.chart.chartStatus === 'success') {
if (
props.chart.chartStatus === 'success' &&
prevChartStatus !== 'success'
) {
controlsTransferred?.forEach(controlName => {
shouldUpdateControls = false;
if (!isDefined(props.controls[controlName])) {
return;
}
if (Array.isArray(props.controls[controlName].value)) {
const alteredControls = ensureIsArray(
props.controls[controlName].value,
)?.map(removeDatasourceWarningFromControl);
props.actions.setControlValue(controlName, alteredControls);
} else {
props.actions.setControlValue(
controlName,
removeDatasourceWarningFromControl(
const alteredControls = Array.isArray(props.controls[controlName].value)
? ensureIsArray(props.controls[controlName].value)?.map(
removeDatasourceWarningFromControl,
)
: removeDatasourceWarningFromControl(
props.controls[controlName].value,
),
);
);
if (shouldUpdateControls) {
props.actions.setControlValue(controlName, alteredControls);
}
});
}
}, [
controlsTransferred,
prevChartStatus,
props.actions,
props.chart.chartStatus,
props.controls,