feat: disable edits on external assets (#19344)

* feat: disable edits on external assets * Update tests
2026-04-26 19:44:58 +00:00 · 2022-03-28 16:32:57 -07:00
parent b689ac2d11
commit d304849b46
21 changed files with 86 additions and 11 deletions
--- a/superset-frontend/src/components/Datasource/DatasourceModal.tsx
+++ b/superset-frontend/src/components/Datasource/DatasourceModal.tsx
@@ -226,7 +226,18 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({
            buttonStyle="primary"
            data-test="datasource-modal-save"
            onClick={onClickSave}
-            disabled={isSaving || errors.length > 0}
+            disabled={
+              isSaving ||
+              errors.length > 0 ||
+              currentDatasource.is_managed_externally
+            }
+            tooltip={
+              currentDatasource.is_managed_externally
+                ? t(
+                    "This dataset is managed externally, and can't be edited in Superset",
+                  )
+                : ''
+            }
          >
            {t('Save')}
          </Button>