feat: disable edits on external assets (#19344)

* feat: disable edits on external assets

* Update tests
This commit is contained in:
Beto Dealmeida
2022-03-28 16:32:57 -07:00
committed by GitHub
parent b689ac2d11
commit d304849b46
21 changed files with 86 additions and 11 deletions

View File

@@ -817,12 +817,24 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
return [];
};
const renderEditModalFooter = () => (
const renderEditModalFooter = (db: Partial<DatabaseObject> | null) => (
<>
<StyledFooterButton key="close" onClick={onClose}>
{t('Close')}
</StyledFooterButton>
<StyledFooterButton key="submit" buttonStyle="primary" onClick={onSave}>
<StyledFooterButton
key="submit"
buttonStyle="primary"
onClick={onSave}
disabled={db?.is_managed_externally}
tooltip={
db?.is_managed_externally
? t(
"This database is managed externally, and can't be edited in Superset",
)
: ''
}
>
{t('Finish')}
</StyledFooterButton>
</>
@@ -1033,7 +1045,7 @@ const DatabaseModal: FunctionComponent<DatabaseModalProps> = ({
title={
<h4>{isEditMode ? t('Edit database') : t('Connect a database')}</h4>
}
footer={isEditMode ? renderEditModalFooter() : renderModalFooter()}
footer={isEditMode ? renderEditModalFooter(db) : renderModalFooter()}
>
<StyledStickyHeader>
<TabHeader>