From d310dfdc79174e759919d702195287affbb45ae5 Mon Sep 17 00:00:00 2001 From: Maxime Beauchemin Date: Sun, 24 Aug 2025 16:54:22 -0700 Subject: [PATCH] fix: Match workflow conditions with actual showtime CLI output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Update output extraction to use 'sync_needed' and 'target_sha' to match what showtime CLI actually returns. This fixes the issue where sync steps were skipped despite sync_needed=true. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .github/workflows/showtime-trigger.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/showtime-trigger.yml b/.github/workflows/showtime-trigger.yml index 2dec40c5759..3cd8ec0f82b 100644 --- a/.github/workflows/showtime-trigger.yml +++ b/.github/workflows/showtime-trigger.yml @@ -79,15 +79,15 @@ jobs: OUTPUT=$(python -m showtime sync $PR_NUM --check-only) echo "$OUTPUT" - # Extract outputs for conditional steps - ACTION=$(echo "$OUTPUT" | grep "action_needed=" | cut -d'=' -f2) + # Extract outputs for conditional steps (match showtime CLI output) BUILD=$(echo "$OUTPUT" | grep "build_needed=" | cut -d'=' -f2) - DEPLOY=$(echo "$OUTPUT" | grep "deploy_needed=" | cut -d'=' -f2) + SYNC=$(echo "$OUTPUT" | grep "sync_needed=" | cut -d'=' -f2) + TARGET_SHA=$(echo "$OUTPUT" | grep "target_sha=" | cut -d'=' -f2) - echo "action_needed=$ACTION" >> $GITHUB_OUTPUT echo "build_needed=$BUILD" >> $GITHUB_OUTPUT - echo "deploy_needed=$DEPLOY" >> $GITHUB_OUTPUT + echo "sync_needed=$SYNC" >> $GITHUB_OUTPUT echo "pr_number=$PR_NUM" >> $GITHUB_OUTPUT + echo "target_sha=$TARGET_SHA" >> $GITHUB_OUTPUT - name: Get SHA for potential build id: sha @@ -172,7 +172,7 @@ jobs: echo "docker_tag=$CUSTOM_TAG" >> $GITHUB_OUTPUT - name: Execute sync deployment - if: steps.check.outputs.deploy_needed == 'true' + if: steps.check.outputs.sync_needed == 'true' run: | PR_NUM="${{ steps.check.outputs.pr_number }}"