QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: upgrade mypy and add type guards (#16227)

Browse Source
This commit is contained in:
Ville Brofeldt
2021-08-14 06:31:45 +03:00
committed by GitHub
parent 9b2dffeb1d
commit d46dc9aa45
9 changed files with 29 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/unit_tests/core_tests.py
View File

@@ -23,6 +23,7 @@ from superset.utils.core import (
GenericDataType,
get_metric_name,
get_metric_names,
is_adhoc_metric,
)
STR_METRIC = "my_metric"
@@ -91,3 +92,9 @@ def test_get_metric_names():
assert get_metric_names(
[STR_METRIC, SIMPLE_SUM_ADHOC_METRIC, SQL_ADHOC_METRIC]
) == ["my_metric", "my SUM", "my_sql"]
def test_is_adhoc_metric():
assert is_adhoc_metric(STR_METRIC) is False
assert is_adhoc_metric(SIMPLE_SUM_ADHOC_METRIC) is True
assert is_adhoc_metric(SQL_ADHOC_METRIC) is True