QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-24 18:44:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(utils): fix off-by-one error in how rolling window's min_periods truncates dataframe (#27388)

Browse Source
This commit is contained in:
Sam Firke
2024-03-21 18:06:36 -04:00
committed by GitHub
parent bfe55b9ded
commit d4d8625ab8
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/unit_tests/pandas_postprocessing/test_rolling.py
View File

@@ -107,7 +107,7 @@ def test_rolling():
)
def test_rolling_should_empty_df():
def test_rolling_min_periods_trims_correctly():
pivot_df = pp.pivot(
df=single_metric_df,
index=["dttm"],
@@ -121,7 +121,7 @@ def test_rolling_should_empty_df():
min_periods=2,
columns={"sum_metric": "sum_metric"},
)
assert rolling_df.empty is True
assert len(rolling_df) == 1
def test_rolling_after_pivot_with_single_metric():