QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused code (#8300)

Browse Source
This commit is contained in:
Krist Wongsuphasawat
2019-09-30 16:57:35 -07:00
committed by Grace Guo
parent 25e2517dcb
commit d55fe54198
13 changed files with 11 additions and 502 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
superset/assets/spec/javascripts/modules/colors_spec.jsx
View File

@@ -1,47 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { hexToRGB } from '../../../src/modules/colors';
describe('hexToRGB', () => {
it('is a function', () => {
expect(typeof hexToRGB).toBe('function');
});
it('hexToRGB converts properly', () => {
expect(hexToRGB('#FFFFFF')).toEqual(expect.arrayContaining([255, 255, 255, 255]));
expect(hexToRGB('#000000')).toEqual(expect.arrayContaining([0, 0, 0, 255]));
expect(hexToRGB('#FF0000')).toEqual(expect.arrayContaining([255, 0, 0, 255]));
expect(hexToRGB('#00FF00')).toEqual(expect.arrayContaining([0, 255, 0, 255]));
expect(hexToRGB('#0000FF')).toEqual(expect.arrayContaining([0, 0, 255, 255]));
});
it('works with falsy values', () => {
expect(hexToRGB()).toEqual([0, 0, 0, 255]);
/* eslint-disable quotes */
[false, 0, -0, 0.0, '', "", ``, null, undefined, NaN].forEach((value) => {
expect(hexToRGB(value)).toEqual(expect.arrayContaining([0, 0, 0, 255]));
});
});
it('takes and alpha argument', () => {
expect(hexToRGB('#FF0000', 128)).toEqual(expect.arrayContaining([255, 0, 0, 128]));
expect(hexToRGB('#000000', 100)).toEqual(expect.arrayContaining([0, 0, 0, 100]));
expect(hexToRGB('#ffffff', 0)).toEqual(expect.arrayContaining([255, 255, 255, 0]));
});
});

42
superset/assets/spec/javascripts/modules/geo_spec.jsx
View File

@@ -1,42 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import { unitToRadius } from '../../../src/modules/geo';
const METER_TO_MILE = 1609.34;
describe('unitToRadius', () => {
it('converts to square meters', () => {
expect(unitToRadius('square_m', 4 * Math.PI)).toBe(2);
});
it('converts to square kilometers', () => {
expect(unitToRadius('square_km', 25 * Math.PI)).toBe(5000);
});
it('converts to radius meters', () => {
expect(unitToRadius('radius_m', 1000)).toBe(1000);
});
it('converts to radius km', () => {
expect(unitToRadius('radius_km', 1)).toBe(1000);
});
it('converts to radius miles', () => {
expect(unitToRadius('radius_miles', 1)).toBe(METER_TO_MILE);
});
it('converts to square miles', () => {
expect(unitToRadius('square_miles', 25 * Math.PI)).toBe(5000 * (METER_TO_MILE / 1000));
});
});

32
superset/assets/spec/javascripts/modules/sandbox_spec.jsx
View File

@@ -1,32 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import sandboxedEval from '../../../src/modules/sandbox';
describe('sandboxedEval', () => {
it('works like a basic eval', () => {
expect(sandboxedEval('100')).toBe(100);
expect(sandboxedEval('v => v * 2')(5)).toBe(10);
});
it('d3 is in context and works', () => {
expect(sandboxedEval("l => _.find(l, s => s === 'bar')")(['foo', 'bar'])).toBe('bar');
});
it('passes context as expected', () => {
expect(sandboxedEval('foo', { foo: 'bar' })).toBe('bar');
});
});

99
superset/assets/spec/javascripts/modules/time_spec.js
View File

@@ -1,99 +0,0 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import moment from 'moment';
import { getPlaySliderParams, truncate } from '../../../src/modules/time';
describe('truncate', () => {
it('truncates timestamps', () => {
const timestamp = moment('2018-03-03T03:03:03.333');
const isoDurations = [
// basic units
[moment.duration('PT1S'), moment('2018-03-03T03:03:03')],
[moment.duration('PT1M'), moment('2018-03-03T03:03:00')],
[moment.duration('PT1H'), moment('2018-03-03T03:00:00')],
[moment.duration('P1D'), moment('2018-03-03T00:00:00')],
[moment.duration('P1M'), moment('2018-03-01T00:00:00')],
[moment.duration('P1Y'), moment('2018-01-01T00:00:00')],
// durations that are multiples
[moment.duration('PT2H'), moment('2018-03-03T02:00:00')],
[moment.duration('P2D'), moment('2018-03-03T00:00:00')],
];
let result;
isoDurations.forEach(([step, expected]) => {
result = truncate(timestamp, step);
expect(result.format()).toBe(expected.format());
});
});
});
describe('getPlaySliderParams', () => {
it('is a function', () => {
expect(typeof getPlaySliderParams).toBe('function');
});
it('handles durations', () => {
const timestamps = [
moment('2018-01-01T00:00:00'),
moment('2018-01-02T00:00:00'),
moment('2018-01-03T00:00:00'),
moment('2018-01-04T00:00:00'),
moment('2018-01-05T00:00:00'),
moment('2018-01-06T00:00:00'),
moment('2018-01-07T00:00:00'),
moment('2018-01-08T00:00:00'),
moment('2018-01-09T00:00:00'),
moment('2018-01-10T00:00:00'),
].map(d => parseInt(d.format('x'), 10));
const { start, end, getStep, values, disabled } = getPlaySliderParams(timestamps, 'P2D');
expect(moment(start).format()).toBe(moment('2018-01-01T00:00:00').format());
expect(moment(end).format()).toBe(moment('2018-01-11T00:00:00').format());
expect(getStep(start)).toBe(2 * 24 * 60 * 60 * 1000);
expect(values.map(v => moment(v).format())).toEqual([
moment('2018-01-01T00:00:00').format(),
moment('2018-01-03T00:00:00').format(),
]);
expect(disabled).toBe(false);
});
it('handles intervals', () => {
const timestamps = [
moment('2018-01-01T00:00:00'),
moment('2018-01-02T00:00:00'),
moment('2018-01-03T00:00:00'),
moment('2018-01-04T00:00:00'),
moment('2018-01-05T00:00:00'),
moment('2018-01-06T00:00:00'),
moment('2018-01-07T00:00:00'),
moment('2018-01-08T00:00:00'),
moment('2018-01-09T00:00:00'),
moment('2018-01-10T00:00:00'),
].map(d => parseInt(d.format('x'), 10));
// 1970-01-03 was a Saturday
const { start, end, getStep, values, disabled } = getPlaySliderParams(timestamps, 'P1W/1970-01-03T00:00:00Z');
expect(moment(start).format()).toBe(moment('2017-12-30T00:00:00Z').format()); // Saturday
expect(moment(end).format()).toBe(moment('2018-01-13T00:00:00Z').format()); // Saturday
expect(getStep(start)).toBe(7 * 24 * 60 * 60 * 1000);
expect(values.map(v => moment(v).format())).toEqual([
moment('2017-12-30T00:00:00Z').format(),
moment('2018-01-06T00:00:00Z').format(),
]);
expect(disabled).toBe(false);
});
});

8
superset/assets/spec/javascripts/modules/utils_spec.jsx
View File

@@ -19,7 +19,6 @@
import {
formatSelectOptionsForRange,
mainMetric,
roundDecimal,
} from '../../../src/modules/utils';
describe('utils', () => {
@@ -66,11 +65,4 @@ describe('utils', () => {
expect(mainMetric(metrics)).toBe('foo');
});
});
describe('roundDecimal', () => {
it('rounding method to limit the number of decimal digits', () => {
expect(roundDecimal(1.139, 2)).toBe(1.14);
expect(roundDecimal(1.13929, 3)).toBe(1.139);
expect(roundDecimal(1.13929)).toBe(1);
});
});
});