From d5602a6017cbc5532ebe59d2cfcec50cc42e9c03 Mon Sep 17 00:00:00 2001 From: Kamil Gabryjelski Date: Fri, 6 Aug 2021 17:59:22 +0200 Subject: [PATCH] fix(explore): revert dnd column dependency array change to fix infinite rerenders (#16115) * fix(explore): revert dnd column dependency array change to fix infinite rerenders * Remove console.log * Remove comment (cherry picked from commit 772da8de6353f01ea1c64037af9695d5f10b71e4) --- .../controls/DndColumnSelectControl/DndColumnSelect.tsx | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx index 32097b256ca..e8f64db146c 100644 --- a/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx +++ b/superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndColumnSelect.tsx @@ -66,9 +66,7 @@ export const DndColumnSelect = (props: LabelProps) => { ) { onChange(optionSelectorValues); } - // when options change, that means that the dataset has changed - // so we have to check if values are still applicable. - }, [options, value, optionSelector]); + }, [JSON.stringify(value), JSON.stringify(optionSelector.getValues())]); // useComponentDidUpdate to avoid running this for the first render, to avoid // calling onChange when the initial value is not valid for the dataset