QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Embrace the walrus operator (#24127)

Browse Source
This commit is contained in:
John Bodley
2023-05-19 00:37:13 -07:00
committed by GitHub
parent 6b5459121f
commit d583ca9ef5
54 changed files with 100 additions and 185 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset/datasets/commands/importers/v1/utils.py
View File

@@ -62,8 +62,7 @@ def get_sqla_type(native_type: str) -> VisitableType:
if native_type.upper() in type_map:
return type_map[native_type.upper()]
match = VARCHAR.match(native_type)
if match:
if match := VARCHAR.match(native_type):
size = int(match.group(1))
return String(size)

6
superset/datasets/commands/update.py
View File

@@ -114,13 +114,11 @@ class UpdateDatasetCommand(UpdateMixin, BaseCommand):
exceptions.append(DatasetEndpointUnsafeValidationError())
# Validate columns
columns = self._properties.get("columns")
if columns:
if columns := self._properties.get("columns"):
self._validate_columns(columns, exceptions)
# Validate metrics
metrics = self._properties.get("metrics")
if metrics:
if metrics := self._properties.get("metrics"):
self._validate_metrics(metrics, exceptions)
if exceptions: