diff --git a/RESOURCES/FEATURE_FLAGS.md b/RESOURCES/FEATURE_FLAGS.md index 8a683ced058..577e47711c9 100644 --- a/RESOURCES/FEATURE_FLAGS.md +++ b/RESOURCES/FEATURE_FLAGS.md @@ -44,7 +44,6 @@ These features are **finished** but currently being tested. They are usable, but - CONFIRM_DASHBOARD_DIFF - DRILL_TO_DETAIL - DYNAMIC_PLUGINS: [(docs)](https://superset.apache.org/docs/installation/running-on-kubernetes) -- ENABLE_JAVASCRIPT_CONTROLS - ESTIMATE_QUERY_COST - GENERIC_CHART_AXES - GLOBAL_ASYNC_QUERIES [(docs)](https://github.com/apache/superset/blob/master/CONTRIBUTING.md#async-chart-queries) @@ -88,6 +87,7 @@ These features flags currently default to True and **will be removed in a future - DASHBOARD_FILTERS_EXPERIMENTAL - DASHBOARD_NATIVE_FILTERS - ENABLE_EXPLORE_JSON_CSRF_PROTECTION +- ENABLE_JAVASCRIPT_CONTROLS - ENABLE_TEMPLATE_REMOVE_FILTERS - GENERIC_CHART_AXES - KV_STORE diff --git a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts index 7b8ee63510e..f4a2054dbf2 100644 --- a/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts +++ b/superset-frontend/packages/superset-ui-core/src/utils/featureFlags.ts @@ -39,6 +39,7 @@ export enum FeatureFlag { EMBEDDABLE_CHARTS = 'EMBEDDABLE_CHARTS', EMBEDDED_SUPERSET = 'EMBEDDED_SUPERSET', ENABLE_ADVANCED_DATA_TYPES = 'ENABLE_ADVANCED_DATA_TYPES', + /** @deprecated */ ENABLE_JAVASCRIPT_CONTROLS = 'ENABLE_JAVASCRIPT_CONTROLS', ENABLE_TEMPLATE_PROCESSING = 'ENABLE_TEMPLATE_PROCESSING', ENABLE_TEMPLATE_REMOVE_FILTERS = 'ENABLE_TEMPLATE_REMOVE_FILTERS', diff --git a/superset/config.py b/superset/config.py index b5a05da616b..0259e4d50be 100644 --- a/superset/config.py +++ b/superset/config.py @@ -423,7 +423,7 @@ DEFAULT_FEATURE_FLAGS: dict[str, bool] = { # this enables programmers to customize certain charts (like the # geospatial ones) by inputting javascript in controls. This exposes # an XSS security vulnerability - "ENABLE_JAVASCRIPT_CONTROLS": False, + "ENABLE_JAVASCRIPT_CONTROLS": False, # deprecated "KV_STORE": False, # deprecated # When this feature is enabled, nested types in Presto will be # expanded into extra columns and/or arrays. This is experimental,