QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-09-01 13:01:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(frontend): Migrate from describe/it to flat test() pattern (#35305)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Evan Rusackas
2025-09-28 11:45:33 -07:00
committed by GitHub
co-authored by Claude
parent ff102aadb3
commit d62249d13f
255 changed files with 2003 additions and 1540 deletions
Download Patch File Download Diff File Expand all files Collapse all files
superset-frontend/src/SqlLab/components/SaveQuery/SaveQuery.test.tsx
+11 -10
View File
@@ -64,8 +64,9 @@ const splitSaveBtnProps = {
const middlewares = [thunk];
const mockStore = configureStore(middlewares);
// eslint-disable-next-line no-restricted-globals -- TODO: Migrate from describe blocks
describe('SavedQuery', () => {
it('doesnt render save button when allows_virtual_table_explore is undefined', async () => {
test('doesnt render save button when allows_virtual_table_explore is undefined', async () => {
const noRenderProps = {
...mockedProps,
database: {
@@ -84,7 +85,7 @@ describe('SavedQuery', () => {
);
});
it('renders a non-split save button when allows_virtual_table_explore is not enabled', () => {
test('renders a non-split save button when allows_virtual_table_explore is not enabled', () => {
render(<SaveQuery {...mockedProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -95,7 +96,7 @@ describe('SavedQuery', () => {
expect(saveBtn).toBeVisible();
});
it('renders a save query modal when user clicks save button', () => {
test('renders a save query modal when user clicks save button', () => {
render(<SaveQuery {...mockedProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -111,7 +112,7 @@ describe('SavedQuery', () => {
expect(saveQueryModalHeader).toBeInTheDocument();
});
it('renders the save query modal UI', () => {
test('renders the save query modal UI', () => {
render(<SaveQuery {...mockedProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -146,7 +147,7 @@ describe('SavedQuery', () => {
expect(cancelBtn).toBeInTheDocument();
});
it('renders a "save as new" and "update" button if query already exists', () => {
test('renders a "save as new" and "update" button if query already exists', () => {
render(<SaveQuery {...mockedProps} />, {
useRedux: true,
store: mockStore({
@@ -171,7 +172,7 @@ describe('SavedQuery', () => {
expect(updateBtn).toBeInTheDocument();
});
it('renders a split save button when allows_virtual_table_explore is enabled', async () => {
test('renders a split save button when allows_virtual_table_explore is enabled', async () => {
render(<SaveQuery {...splitSaveBtnProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -186,7 +187,7 @@ describe('SavedQuery', () => {
});
});
it('renders a save dataset modal when user clicks "save dataset" menu item', async () => {
test('renders a save dataset modal when user clicks "save dataset" menu item', async () => {
render(<SaveQuery {...splitSaveBtnProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -205,7 +206,7 @@ describe('SavedQuery', () => {
expect(saveDatasetHeader).toBeInTheDocument();
});
it('renders the save dataset modal UI', async () => {
test('renders the save dataset modal UI', async () => {
render(<SaveQuery {...splitSaveBtnProps} />, {
useRedux: true,
store: mockStore(mockState),
@@ -246,7 +247,7 @@ describe('SavedQuery', () => {
expect(overwritePlaceholderText).toBeInTheDocument();
});
it('modal stays open while save is in progress and closes after completion', async () => {
test('modal stays open while save is in progress and closes after completion', async () => {
let resolveSave: () => void;
const savePromise = new Promise<void>(resolve => {
resolveSave = resolve;
@@ -290,7 +291,7 @@ describe('SavedQuery', () => {
expect(mockOnSave).toHaveBeenCalledTimes(1);
});
it('handles save with a new tab that has no changes', async () => {
test('handles save with a new tab that has no changes', async () => {
const mockOnSave = jest.fn().mockResolvedValue(undefined);
// Mock state for a new tab with default SQL