diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx index fa9ab3c4183..864db364a38 100644 --- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx +++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/Vertical.tsx @@ -288,8 +288,15 @@ const VerticalFilterBar: FC = ({
{!isInitialized ? ( -
- +
+
) : (
diff --git a/superset-frontend/src/explore/components/SaveModal.tsx b/superset-frontend/src/explore/components/SaveModal.tsx old mode 100644 new mode 100755 index 5dff843dbbb..6e72769f078 --- a/superset-frontend/src/explore/components/SaveModal.tsx +++ b/superset-frontend/src/explore/components/SaveModal.tsx @@ -93,11 +93,6 @@ export const StyledModal = styled(Modal)` .ant-modal-body { overflow: visible; } - i { - position: absolute; - top: -${({ theme }) => theme.sizeUnit * 5.25}px; - left: ${({ theme }) => theme.sizeUnit * 26.75}px; - } `; class SaveModal extends Component { @@ -172,17 +167,21 @@ class SaveModal extends Component { this.setState({ newSliceName: event.target.value }); } - onDashboardChange = async (dashboard: { - label: string; - value: string | number; - }) => { + onDashboardChange = async ( + dashboard: + | { + label: string; + value: string | number; + } + | undefined, + ) => { this.setState({ dashboard, tabsData: [], selectedTab: undefined, }); - if (typeof dashboard.value === 'number') { + if (dashboard && typeof dashboard.value === 'number') { await this.loadTabs(dashboard.value); } };