QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-09 18:05:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(theming): Fix ag-grid theming regression in SQL Lab (#34675)

Browse Source 
Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
Maxime Beauchemin
2025-08-13 16:21:47 -07:00
committed by GitHub
parent bce476c4a2
commit d79fc92a1a
26 changed files with 520 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/filterValueGetter.ts
View File

@@ -17,7 +17,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { ValueGetterParams } from 'ag-grid-community';
import { ValueGetterParams } from '@superset-ui/core/components/ThemedAgGridReact';
const filterValueGetter = (params: ValueGetterParams) => {
const raw = params.data[params.colDef.field as string];

5
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/formatValue.ts
View File

@@ -25,7 +25,10 @@ import {
isProbablyHTML,
sanitizeHtml,
} from '@superset-ui/core';
import { ValueFormatterParams, ValueGetterParams } from 'ag-grid-community';
import {
ValueFormatterParams,
ValueGetterParams,
} from '@superset-ui/core/components/ThemedAgGridReact';
import { DataColumnMeta, InputColumn } from '../types';
import DateWithFormatter from './DateWithFormatter';

2
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getCellClass.ts
View File

@@ -17,7 +17,7 @@
* under the License.
*/
import { CellClassParams } from 'ag-grid-community';
import { CellClassParams } from '@superset-ui/core/components/ThemedAgGridReact';
import { InputColumn } from '../types';
type GetCellClassParams = CellClassParams & {

2
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getCellStyle.ts
View File

@@ -18,7 +18,7 @@
*/
import { ColorFormatters } from '@superset-ui/chart-controls';
import { CellClassParams } from 'ag-grid-community';
import { CellClassParams } from '@superset-ui/core/components/ThemedAgGridReact';
import { BasicColorFormatterType, InputColumn } from '../types';
type CellStyleParams = CellClassParams & {

5
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/getInitialSortState.ts
View File

@@ -17,7 +17,10 @@
* under the License.
*/
// All ag grid sort related stuff
import { GridState, SortModelItem } from 'ag-grid-community';
import {
GridState,
SortModelItem,
} from '@superset-ui/core/components/ThemedAgGridReact';
import { SortByItem } from '../types';
const getInitialSortState = (sortBy?: SortByItem[]): SortModelItem[] => {

2
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useColDefs.ts
View File

@@ -17,7 +17,7 @@
* specific language governing permissions and limitations
* under the License.
*/
import { ColDef } from 'ag-grid-community';
import { ColDef } from '@superset-ui/core/components/ThemedAgGridReact';
import { useCallback, useMemo } from 'react';
import { DataRecord, GenericDataType } from '@superset-ui/core';
import { ColorFormatters } from '@superset-ui/chart-controls';

2
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/useTableTheme.ts
View File

@@ -21,7 +21,7 @@ import {
colorSchemeDark,
colorSchemeLight,
themeQuartz,
} from 'ag-grid-community';
} from '@superset-ui/core/components/ThemedAgGridReact';
// eslint-disable-next-line import/no-extraneous-dependencies
import tinycolor from 'tinycolor2';