QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-23 01:55:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ag-grid): Ag Grid Date Filter timezone correction (#36270)

Browse Source
This commit is contained in:
amaannawab923
2026-01-07 08:27:20 -03:00
committed by GitHub
parent 9968393e4c
commit d7d94ba640
2 changed files with 167 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

58
superset-frontend/plugins/plugin-chart-ag-grid-table/src/utils/dateFilterComparator.ts
View File

@@ -17,25 +17,53 @@
* under the License.
*/
const dateFilterComparator = (filterDate: Date, cellValue: Date) => {
/**
* Timezone-safe date comparator for AG Grid date filters.
*
* This comparator normalizes both dates to UTC midnight before comparison,
* fixing the off-by-one day bug that occurs when:
* - User's timezone differs from UTC
* - Data is stored in UTC but filtered in local time
* - Midnight boundary crossing due to timezone offset
*
* Bug references:
* - AG Grid Issue #8611: UTC Date Editor Problem
* - AG Grid Issue #3921: DateFilter timezone regression
*
*/
const dateFilterComparator = (
filterDate: Date,
cellValue: Date | null | undefined,
) => {
if (cellValue == null) {
return -1;
}
const cellDate = new Date(cellValue);
cellDate.setHours(0, 0, 0, 0);
if (Number.isNaN(cellDate?.getTime())) return -1;
if (Number.isNaN(cellDate.getTime())) {
return -1;
}
const cellDay = cellDate.getDate();
const cellMonth = cellDate.getMonth();
const cellYear = cellDate.getFullYear();
// Filter date from AG Grid uses local timezone (what the user selected)
const filterUTC = Date.UTC(
filterDate.getFullYear(),
filterDate.getMonth(),
filterDate.getDate(),
);
const filterDay = filterDate.getDate();
const filterMonth = filterDate.getMonth();
const filterYear = filterDate.getFullYear();
// Cell data is in UTC - extract UTC components to compare actual dates
const cellUTC = Date.UTC(
cellDate.getUTCFullYear(),
cellDate.getUTCMonth(),
cellDate.getUTCDate(),
);
if (cellYear < filterYear) return -1;
if (cellYear > filterYear) return 1;
if (cellMonth < filterMonth) return -1;
if (cellMonth > filterMonth) return 1;
if (cellDay < filterDay) return -1;
if (cellDay > filterDay) return 1;
if (cellUTC < filterUTC) {
return -1;
}
if (cellUTC > filterUTC) {
return 1;
}
return 0;
};