[superset-client] use getClientErrorObject for client error handling (#6163)

* [superset-client] use getClientErrorObject for client error handling

* fix getClientErrorObject json parsing

* fix getClientErrorObject test typos

* kick build

superset/assets/spec/javascripts/modules/utils_spec.jsx

@@ -5,27 +5,34 @@ import {
   d3TimeFormatPreset,
   defaultNumberFormatter,
   mainMetric,
+  getClientErrorObject,
 } from '../../../src/modules/utils';
 
 describe('utils', () => {
-  it('formatSelectOptionsForRange', () => {
-    expect(formatSelectOptionsForRange(0, 4)).toEqual([
-      [0, '0'],
-      [1, '1'],
-      [2, '2'],
-      [3, '3'],
-      [4, '4'],
-    ]);
-    expect(formatSelectOptionsForRange(1, 2)).toEqual([
-      [1, '1'],
-      [2, '2'],
-    ]);
+  describe('formatSelectOptionsForRange', () => {
+    it('returns an array of arrays for the range specified (inclusive)', () => {
+      expect(formatSelectOptionsForRange(0, 4)).toEqual([
+        [0, '0'],
+        [1, '1'],
+        [2, '2'],
+        [3, '3'],
+        [4, '4'],
+      ]);
+      expect(formatSelectOptionsForRange(1, 2)).toEqual([
+        [1, '1'],
+        [2, '2'],
+      ]);
+    });
   });
-  it('d3format', () => {
-    expect(d3format('.3s', 1234)).toBe('1.23k');
-    expect(d3format('.3s', 1237)).toBe('1.24k');
-    expect(d3format('', 1237)).toBe('1.24k');
+
+  describe('d3format', () => {
+    it('returns a string formatted number as specified', () => {
+      expect(d3format('.3s', 1234)).toBe('1.23k');
+      expect(d3format('.3s', 1237)).toBe('1.24k');
+      expect(d3format('', 1237)).toBe('1.24k');
+    });
   });
+
   describe('d3FormatPreset', () => {
     it('is a function', () => {
       expect(typeof d3FormatPreset).toBe('function');
@@ -34,6 +41,7 @@ describe('utils', () => {
       expect(d3FormatPreset('.3s')(3000000)).toBe('3.00M');
     });
   });
+
   describe('d3TimeFormatPreset', () => {
     it('is a function', () => {
       expect(typeof d3TimeFormatPreset).toBe('function');
@@ -42,6 +50,7 @@ describe('utils', () => {
       expect(d3FormatPreset('smart_date')(0)).toBe('1970');
     });
   });
+
   describe('defaultNumberFormatter', () => {
     expect(defaultNumberFormatter(10)).toBe('10');
     expect(defaultNumberFormatter(1)).toBe('1');
@@ -61,6 +70,7 @@ describe('utils', () => {
     expect(defaultNumberFormatter(-111000000)).toBe('-111M');
     expect(defaultNumberFormatter(-0.23)).toBe('-230m');
   });
+
   describe('mainMetric', () => {
     it('is null when no options', () => {
       expect(mainMetric([])).toBeUndefined();
@@ -88,4 +98,44 @@ describe('utils', () => {
       expect(mainMetric(metrics)).toBe('foo');
     });
   });
+
+  describe('getClientErrorObject', () => {
+    it('Returns a Promise', () => {
+      const response = getClientErrorObject('error');
+      expect(response.constructor === Promise).toBe(true);
+    });
+
+    it('Returns a Promise that resolves to an object with an error key', () => {
+      const error = 'error';
+
+      return getClientErrorObject(error).then((errorObj) => {
+        expect(errorObj).toMatchObject({ error });
+      });
+    });
+
+    it('Handles Response that can be parsed as json', () => {
+      const jsonError = { something: 'something', error: 'Error message' };
+      const jsonErrorString = JSON.stringify(jsonError);
+
+      return getClientErrorObject(new Response(jsonErrorString)).then((errorObj) => {
+        expect(errorObj).toMatchObject(jsonError);
+      });
+    });
+
+    it('Handles Response that can be parsed as text', () => {
+      const textError = 'Hello I am a text error';
+
+      return getClientErrorObject(new Response(textError)).then((errorObj) => {
+        expect(errorObj).toMatchObject({ error: textError });
+      });
+    });
+
+    it('Handles plain text as input', () => {
+      const error = 'error';
+
+      return getClientErrorObject(error).then((errorObj) => {
+        expect(errorObj).toMatchObject({ error });
+      });
+    });
+  });
 });