mirror of
https://github.com/apache/superset.git
synced 2026-04-27 12:05:24 +00:00
refactor: Removes the Filter Box code (#26328)
Co-authored-by: John Bodley <john.bodley@gmail.com>
This commit is contained in:
committed by
GitHub
parent
591f266543
commit
d9a3c3e1dd
@@ -381,7 +381,11 @@ class TestImportExport(SupersetTestCase):
|
||||
expected_dash, imported_dash, check_position=False, check_slugs=False
|
||||
)
|
||||
self.assertEqual(
|
||||
{"remote_id": 10002, "import_time": 1990},
|
||||
{
|
||||
"remote_id": 10002,
|
||||
"import_time": 1990,
|
||||
"native_filter_configuration": [],
|
||||
},
|
||||
json.loads(imported_dash.json_metadata),
|
||||
)
|
||||
|
||||
@@ -411,7 +415,7 @@ class TestImportExport(SupersetTestCase):
|
||||
f"{e_slc.id}": True,
|
||||
f"{b_slc.id}": False,
|
||||
},
|
||||
# mocked filter_scope metadata
|
||||
# mocked legacy filter_scope metadata
|
||||
"filter_scopes": {
|
||||
str(e_slc.id): {
|
||||
"region": {"scope": ["ROOT_ID"], "immune": [b_slc.id]}
|
||||
@@ -435,15 +439,11 @@ class TestImportExport(SupersetTestCase):
|
||||
expected_json_metadata = {
|
||||
"remote_id": 10003,
|
||||
"import_time": 1991,
|
||||
"filter_scopes": {
|
||||
str(i_e_slc.id): {
|
||||
"region": {"scope": ["ROOT_ID"], "immune": [i_b_slc.id]}
|
||||
}
|
||||
},
|
||||
"expanded_slices": {
|
||||
f"{i_e_slc.id}": True,
|
||||
f"{i_b_slc.id}": False,
|
||||
},
|
||||
"native_filter_configuration": [],
|
||||
}
|
||||
self.assertEqual(
|
||||
expected_json_metadata, json.loads(imported_dash.json_metadata)
|
||||
@@ -489,7 +489,11 @@ class TestImportExport(SupersetTestCase):
|
||||
expected_dash, imported_dash, check_position=False, check_slugs=False
|
||||
)
|
||||
self.assertEqual(
|
||||
{"remote_id": 10004, "import_time": 1992},
|
||||
{
|
||||
"remote_id": 10004,
|
||||
"import_time": 1992,
|
||||
"native_filter_configuration": [],
|
||||
},
|
||||
json.loads(imported_dash.json_metadata),
|
||||
)
|
||||
|
||||
@@ -517,6 +521,7 @@ class TestImportExport(SupersetTestCase):
|
||||
self.assertEqual(imported_slc.changed_by, gamma_user)
|
||||
self.assertEqual(imported_slc.owners, [gamma_user])
|
||||
|
||||
@pytest.mark.skip
|
||||
def test_import_override_dashboard_slice_reset_ownership(self):
|
||||
admin_user = security_manager.find_user(username="admin")
|
||||
self.assertTrue(admin_user)
|
||||
@@ -539,7 +544,6 @@ class TestImportExport(SupersetTestCase):
|
||||
|
||||
# re-import with another user shouldn't change the permissions
|
||||
g.user = admin_user
|
||||
|
||||
dash_with_1_slice = self._create_dashboard_for_import(id_=10300)
|
||||
|
||||
imported_dash_id = import_dashboard(dash_with_1_slice)
|
||||
|
||||
Reference in New Issue
Block a user