QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 00:24:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): batch fix for execute_sql crashes, null timestamps, and deck.gl errors (#38977)

Browse Source
This commit is contained in:
Amin Ghadersohi
2026-03-31 18:50:20 +02:00
committed by GitHub
parent c37a3ec292
commit daefedebcd
10 changed files with 92 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit_tests/mcp_service/sql_lab/tool/test_execute_sql.py
View File

@@ -237,7 +237,7 @@ class TestExecuteSql:
mock_security_manager, # noqa: PT019
mcp_server,
):
"""Test error when database is not found."""
"""Test graceful error when database is not found."""
# mock_security_manager is patched but not used (error happens first)
del mock_security_manager # Silence unused variable warning
mock_db.session.query.return_value.filter_by.return_value.first.return_value = (
@@ -251,8 +251,10 @@ class TestExecuteSql:
}
async with Client(mcp_server) as client:
with pytest.raises(ToolError, match="Database with ID 999 not found"):
await client.call_tool("execute_sql", {"request": request})
result = await client.call_tool("execute_sql", {"request": request})
data = result.structured_content
assert data["success"] is False
assert "Database with ID 999 not found" in data["error"]
@patch("superset.security_manager", new_callable=MagicMock)
@patch("superset.db")
@@ -274,8 +276,10 @@ class TestExecuteSql:
}
async with Client(mcp_server) as client:
with pytest.raises(ToolError, match="Access denied to database"):
await client.call_tool("execute_sql", {"request": request})
result = await client.call_tool("execute_sql", {"request": request})
data = result.structured_content
assert data["success"] is False
assert "Access denied to database" in data["error"]
@patch("superset.security_manager")
@patch("superset.db")