QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 23:55:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: better error message when adding DBs (#13601)

Browse Source 
* WIP

* Adding tests

* Add unit tests

* Show error message

* Fix lint

* Fix after rebase
This commit is contained in:
Beto Dealmeida
2021-03-17 20:29:26 -07:00
committed by GitHub
parent 697cdf26b3
commit db57f90a34
10 changed files with 291 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
superset/databases/api.py
View File

@@ -64,6 +64,7 @@ from superset.databases.schemas import (
TableMetadataResponseSchema,
)
from superset.databases.utils import get_table_metadata
from superset.exceptions import SupersetErrorException
from superset.extensions import security_manager
from superset.models.core import Database
from superset.typing import FlaskResponse
@@ -608,6 +609,8 @@ class DatabaseRestApi(BaseSupersetModelRestApi):
return self.response(200, message="OK")
except DatabaseTestConnectionFailedError as ex:
return self.response_422(message=str(ex))
except SupersetErrorException as ex:
return self.response(ex.status, message=ex.error.message)
@expose("/<int:pk>/related_objects/", methods=["GET"])
@protect()