feat: [dashboard] notification and warning for auto force refresh (#9886)

* feat: [dashboard] notification and warning for auto force refresh

* fix review comments
This commit is contained in:
Grace Guo
2020-06-03 10:20:56 -07:00
committed by GitHub
parent ee777acd57
commit dcac860f3e
13 changed files with 156 additions and 6 deletions

View File

@@ -35,6 +35,7 @@ import { getActiveFilters } from '../util/activeDashboardFilters';
const propTypes = {
addSuccessToast: PropTypes.func.isRequired,
addDangerToast: PropTypes.func.isRequired,
dashboardInfo: PropTypes.object.isRequired,
dashboardId: PropTypes.number.isRequired,
dashboardTitle: PropTypes.string.isRequired,
hasUnsavedChanges: PropTypes.bool.isRequired,
@@ -45,6 +46,7 @@ const propTypes = {
updateCss: PropTypes.func.isRequired,
forceRefreshAllCharts: PropTypes.func.isRequired,
refreshFrequency: PropTypes.number.isRequired,
shouldPersistRefreshFrequency: PropTypes.bool.isRequired,
setRefreshFrequency: PropTypes.func.isRequired,
startPeriodicRender: PropTypes.func.isRequired,
editMode: PropTypes.bool.isRequired,
@@ -55,11 +57,15 @@ const propTypes = {
expandedSlices: PropTypes.object.isRequired,
onSave: PropTypes.func.isRequired,
showPropertiesModal: PropTypes.func.isRequired,
refreshLimit: PropTypes.number,
refreshWarning: PropTypes.string,
};
const defaultProps = {
colorNamespace: undefined,
colorScheme: undefined,
refreshLimit: 0,
refreshWarning: null,
};
class HeaderActionsDropdown extends React.PureComponent {
@@ -114,8 +120,10 @@ class HeaderActionsDropdown extends React.PureComponent {
const {
dashboardTitle,
dashboardId,
dashboardInfo,
forceRefreshAllCharts,
refreshFrequency,
shouldPersistRefreshFrequency,
editMode,
customCss,
colorNamespace,
@@ -127,6 +135,8 @@ class HeaderActionsDropdown extends React.PureComponent {
userCanEdit,
userCanSave,
isLoading,
refreshLimit,
refreshWarning,
} = this.props;
const emailTitle = t('Superset Dashboard');
@@ -147,10 +157,12 @@ class HeaderActionsDropdown extends React.PureComponent {
addDangerToast={this.props.addDangerToast}
dashboardId={dashboardId}
dashboardTitle={dashboardTitle}
dashboardInfo={dashboardInfo}
saveType={SAVE_TYPE_NEWDASHBOARD}
layout={layout}
expandedSlices={expandedSlices}
refreshFrequency={refreshFrequency}
shouldPersistRefreshFrequency={shouldPersistRefreshFrequency}
customCss={customCss}
colorNamespace={colorNamespace}
colorScheme={colorScheme}
@@ -180,6 +192,8 @@ class HeaderActionsDropdown extends React.PureComponent {
<RefreshIntervalModal
refreshFrequency={refreshFrequency}
refreshLimit={refreshLimit}
refreshWarning={refreshWarning}
onChange={this.changeRefreshInterval}
editMode={editMode}
triggerNode={