fix: process color scheme configs correctly (#17786)

This commit is contained in:
David Aaron Suddjian
2022-01-04 15:27:10 -08:00
committed by GitHub
parent cac704d43b
commit de3d3973a2
2 changed files with 18 additions and 5 deletions

View File

@@ -18,9 +18,12 @@
*/
import {
CategoricalScheme,
ColorScheme,
ColorSchemeConfig,
getCategoricalSchemeRegistry,
getSequentialSchemeRegistry,
SequentialScheme,
SequentialSchemeConfig,
CategoricalAirbnb,
CategoricalD3,
CategoricalEcharts,
@@ -33,9 +36,9 @@ import {
ColorSchemeRegistry,
} from '@superset-ui/core';
function registerColorSchemes(
registry: ColorSchemeRegistry<unknown>,
colorSchemes: (CategoricalScheme | SequentialScheme)[],
function registerColorSchemes<T extends ColorScheme>(
registry: ColorSchemeRegistry<T>,
colorSchemes: T[],
standardDefaultKey: string,
) {
colorSchemes.forEach(scheme => {
@@ -48,9 +51,15 @@ function registerColorSchemes(
}
export default function setupColors(
extraCategoricalColorSchemes: CategoricalScheme[] = [],
extraSequentialColorSchemes: SequentialScheme[] = [],
extraCategoricalColorSchemeConfigs: ColorSchemeConfig[] = [],
extraSequentialColorSchemeConfigs: SequentialSchemeConfig[] = [],
) {
const extraCategoricalColorSchemes = extraCategoricalColorSchemeConfigs.map(
config => new CategoricalScheme(config),
);
const extraSequentialColorSchemes = extraSequentialColorSchemeConfigs.map(
config => new SequentialScheme(config),
);
registerColorSchemes(
// @ts-ignore
getCategoricalSchemeRegistry(),