QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-26 03:24:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: apply standardized form data to tier 2 charts (#20530)

Browse Source
This commit is contained in:
Yongjie Zhao
2022-06-29 16:27:31 +08:00
committed by GitHub
parent 927d066f70
commit de524bc59f
11 changed files with 94 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
superset-frontend/src/explore/controlUtils/standardizedFormData.test.ts
View File

@@ -68,6 +68,9 @@ describe('should collect control values and create SFD', () => {
metrics: ['m2'],
metric_2: 'm3',
size: 'm4',
x: 'm5',
y: 'm6',
secondary_metric: 'm7',
// columns
groupby: ['c1'],
columns: ['c2'],
@@ -75,6 +78,7 @@ describe('should collect control values and create SFD', () => {
groupbyRows: ['c4'],
series: 'c5',
entity: 'c6',
series_columns: ['c7'],
};
const publicControlsFormData = {
// time section
@@ -171,7 +175,15 @@ describe('should collect control values and create SFD', () => {
Object.entries(sharedKey).length,
);
const sfd = new StandardizedFormData(sourceMockFormData);
expect(sfd.serialize().controls.metrics).toEqual(['m1', 'm2', 'm3', 'm4']);
expect(sfd.serialize().controls.metrics).toEqual([
'm1',
'm2',
'm3',
'm4',
'm5',
'm6',
'm7',
]);
expect(sfd.serialize().controls.columns).toEqual([
'c1',
'c2',
@@ -179,6 +191,7 @@ describe('should collect control values and create SFD', () => {
'c4',
'c5',
'c6',
'c7',
]);
});
@@ -193,8 +206,24 @@ describe('should collect control values and create SFD', () => {
expect(formData).toHaveProperty(key);
expect(value).toEqual(publicControlsFormData[key]);
});
expect(formData.columns).toEqual(['c1', 'c2', 'c3', 'c4', 'c5', 'c6']);
expect(formData.metrics).toEqual(['m1', 'm2', 'm3', 'm4']);
expect(formData.columns).toEqual([
'c1',
'c2',
'c3',
'c4',
'c5',
'c6',
'c7',
]);
expect(formData.metrics).toEqual([
'm1',
'm2',
'm3',
'm4',
'm5',
'm6',
'm7',
]);
});
test('should inherit standardizedFormData and memorizedFormData is LIFO', () => {

4
superset-frontend/src/explore/controlUtils/standardizedFormData.ts
View File

@@ -38,6 +38,9 @@ export const sharedMetricsKey = [
'metrics', // via sharedControls, array
'metric_2', // via sharedControls, scalar
'size', // via sharedControls, scalar
'x', // via sharedControls, scalar
'y', // via sharedControls, scalar
'secondary_metric', // via sharedControls, scalar
];
export const sharedColumnsKey = [
'groupby', // via sharedControls, array
@@ -46,6 +49,7 @@ export const sharedColumnsKey = [
'groupbyRows', // via pivot table v2, array
'entity', // via sharedControls, scalar
'series', // via sharedControls, scalar
'series_columns', // via sharedControls, array
];
export const publicControls = [