QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(DB update): Gracefully handle querry error during DB update (#33250)

Browse Source
This commit is contained in:
Vitor Avila
2025-04-25 15:38:59 -03:00
committed by GitHub
parent ac636c73ae
commit de84a534ac
3 changed files with 45 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
tests/unit_tests/commands/databases/update_test.py
View File

@@ -642,3 +642,28 @@ def test_update_without_catalog_change(mocker: MockerFixture) -> None:
UpdateDatabaseCommand(1, {}).run()
update_catalog_attribute.assert_not_called()
def test_update_broken_connection(mocker: MockerFixture) -> None:
"""
Test that updating a database with a broken connection works
even if it has to run a query to get the default catalog.
"""
database = mocker.MagicMock()
database.get_default_catalog.side_effect = Exception("Broken connection")
database.id = 1
new_db = mocker.MagicMock()
new_db.get_default_catalog.return_value = "main"
database_dao = mocker.patch("superset.commands.database.update.DatabaseDAO")
database_dao.find_by_id.return_value = database
database_dao.update.return_value = new_db
mocker.patch("superset.commands.database.update.SyncPermissionsCommand")
update_catalog_attribute = mocker.patch.object(
UpdateDatabaseCommand,
"_update_catalog_attribute",
)
UpdateDatabaseCommand(1, {}).run()
update_catalog_attribute.assert_called_once_with(1, "main")