mirror of
https://github.com/apache/superset.git
synced 2026-04-17 23:25:05 +00:00
Fix js warnings (#2693)
* react: using prop-types package to fix deprecated React.PropTypes property warning https://facebook.github.io/react/warnings/dont-call-proptypes.html * removing babel devDependency because has been deprecated in favor of babel-cli this fixes a warning during `npm install`: ``` npm WARN deprecated babel@6.23.0: In 6.x, the babel package has been deprecated in favor of babel-cli. Check https://opencollective.com/babel to support the Babel maintainers ``` * js: setting ExploreActionButtons.queryEndpoint PropType as required because it's required in the child component DisplayQueryButton * js(tests): using object in expandedSlices prop type of SliceCell tests * js(tests): adding required props to SqlEditor mockedProps * js(tests): adding required prop editorHeight to TabbedSqlEditors mockedProps * js: removing unused moments dependency
This commit is contained in:
committed by
Maxime Beauchemin
parent
903612ac6c
commit
dee36491c5
@@ -10,7 +10,7 @@ describe('SliceCell', () => {
|
||||
const mockedProps = {
|
||||
slice,
|
||||
removeSlice: () => {},
|
||||
expandedSlices: () => {},
|
||||
expandedSlices: {},
|
||||
};
|
||||
it('is valid', () => {
|
||||
expect(
|
||||
|
||||
@@ -14,6 +14,7 @@ describe('ExploreActionButtons', () => {
|
||||
json_endpoint: '',
|
||||
},
|
||||
},
|
||||
queryEndpoint: 'localhost',
|
||||
};
|
||||
|
||||
it('renders', () => {
|
||||
|
||||
@@ -15,6 +15,9 @@ describe('SqlEditor', () => {
|
||||
latestQuery: queries[0],
|
||||
tables: [table],
|
||||
queries,
|
||||
height: '',
|
||||
editorQueries: [],
|
||||
dataPreviewQueries: [],
|
||||
};
|
||||
it('is valid', () => {
|
||||
expect(
|
||||
|
||||
@@ -15,6 +15,7 @@ describe('TabbedSqlEditors', () => {
|
||||
queries: {},
|
||||
queryEditors: initialState.queryEditors,
|
||||
tabHistory: initialState.tabHistory,
|
||||
editorHeight: '',
|
||||
};
|
||||
it('is valid', () => {
|
||||
expect(
|
||||
|
||||
Reference in New Issue
Block a user