QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

[sql lab] specify schema name when generating vanila query (#1096)

Browse Source 
* [sql lab] specify schema name when generating vanila query

* Fixing some react warnings
This commit is contained in:
Maxime Beauchemin
2016-09-12 23:09:18 -07:00
committed by GitHub
parent 1f761c61dd
commit df533d30fc
6 changed files with 18 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
caravel/assets/javascripts/SqlLab/components/VisualizeModal.jsx
View File

@@ -26,6 +26,8 @@ class VisualizeModal extends React.Component {
columns: {},
hints: [],
};
}
componentDidMount() {
this.validate();
}
validate() {
@@ -135,8 +137,8 @@ class VisualizeModal extends React.Component {
/>
),
}));
const alerts = this.state.hints.map((hint) => (
<Alert bsStyle="warning">{hint}</Alert>
const alerts = this.state.hints.map((hint, i) => (
<Alert bsStyle="warning" key={i}>{hint}</Alert>
));
const modal = (
<div className="VisualizeModal">
@@ -191,11 +193,12 @@ class VisualizeModal extends React.Component {
}
VisualizeModal.propTypes = {
query: React.PropTypes.object,
show: React.PropTypes.boolean,
show: React.PropTypes.bool,
onHide: React.PropTypes.function,
};
VisualizeModal.defaultProps = {
show: false,
onHide: () => {},
};
function mapStateToProps() {