QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-20 16:44:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Ensure Flask framework leverages the Flask-SQLAlchemy session (#26200)

Browse Source
This commit is contained in:
John Bodley
2024-01-18 08:27:29 +13:00
committed by GitHub
parent 80a6e25a98
commit df79522160
26 changed files with 314 additions and 388 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
superset/common/query_context_factory.py
View File

@@ -18,7 +18,7 @@ from __future__ import annotations
from typing import Any, TYPE_CHECKING
from superset import app, db
from superset import app
from superset.common.chart_data import ChartDataResultFormat, ChartDataResultType
from superset.common.query_context import QueryContext
from superset.common.query_object import QueryObject
@@ -35,7 +35,7 @@ config = app.config
def create_query_object_factory() -> QueryObjectFactory:
return QueryObjectFactory(config, DatasourceDAO(), db.session)
return QueryObjectFactory(config, DatasourceDAO())
class QueryContextFactory: # pylint: disable=too-few-public-methods
@@ -95,7 +95,6 @@ class QueryContextFactory: # pylint: disable=too-few-public-methods
def _convert_to_model(self, datasource: DatasourceDict) -> BaseDatasource:
return DatasourceDAO.get_datasource(
session=db.session,
datasource_type=DatasourceType(datasource["type"]),
datasource_id=int(datasource["id"]),
)