QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

add feature flag to header bar (#16031)

Browse Source
This commit is contained in:
Elizabeth Thompson
2021-08-02 10:57:29 -07:00
committed by GitHub
parent 39db6a73ee
commit e0576786c3
7 changed files with 391 additions and 50507 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
superset-frontend/src/explore/components/ExploreChartHeader.jsx
View File

@@ -29,6 +29,7 @@ import {
toggleActive,
deleteActiveReport,
} from 'src/reports/actions/reports';
import { isFeatureEnabled, FeatureFlag } from 'src/featureFlags';
import HeaderReportActionsDropdown from 'src/components/ReportModal/HeaderReportActionsDropdown';
import { chartPropShape } from '../../dashboard/util/propShapes';
import ExploreActionButtons from './ExploreActionButtons';
@@ -116,7 +117,7 @@ export class ExploreChartHeader extends React.PureComponent {
componentDidMount() {
const { user, chart } = this.props;
if (user) {
if (user && isFeatureEnabled(FeatureFlag.ALERT_REPORTS)) {
// this is in the case that there is an anonymous user.
this.props.fetchUISpecificReport(
user.userId,
@@ -163,25 +164,29 @@ export class ExploreChartHeader extends React.PureComponent {
renderReportModal() {
const attachedReportExists = !!Object.keys(this.props.reports).length;
return attachedReportExists ? (
<HeaderReportActionsDropdown
showReportModal={this.showReportModal}
hideReportModal={this.hideReportModal}
toggleActive={this.props.toggleActive}
deleteActiveReport={this.props.deleteActiveReport}
/>
) : (
<>
<span
role="button"
title={t('Schedule email report')}
tabIndex={0}
className="action-button"
onClick={this.showReportModal}
>
<Icons.Calendar />
</span>
</>
const canAddReports = isFeatureEnabled(FeatureFlag.ALERT_REPORTS);
return (
(canAddReports || null) &&
(attachedReportExists ? (
<HeaderReportActionsDropdown
showReportModal={this.showReportModal}
hideReportModal={this.hideReportModal}
toggleActive={this.props.toggleActive}
deleteActiveReport={this.props.deleteActiveReport}
/>
) : (
<>
<span
role="button"
title={t('Schedule email report')}
tabIndex={0}
className="action-button"
onClick={this.showReportModal}
>
<Icons.Calendar />
</span>
</>
))
);
}