QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-05-12 19:35:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(mcp): remove @parse_request decorator for cleaner tool schemas (#38918)

Browse Source 
(cherry picked from commit d1903afc69)
This commit is contained in:
Amin Ghadersohi
2026-03-29 22:09:51 +02:00
committed by Michael S. Molina
parent df2a0416eb
commit e08c305396
22 changed files with 39 additions and 98 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
tests/unit_tests/mcp_service/sql_lab/tool/test_save_sql_query.py
View File

@@ -228,9 +228,8 @@ class TestSaveSqlQueryToolLogic:
from superset import db, etc.). We patch at the import source so that
when the function runs, it picks up our mocks.
The @parse_request decorator injects ctx via get_context() and strips
__wrapped__, so we mock get_context and call the decorated function
directly (without unwrapping).
With passthrough decorators, we call the tool function directly
and pass a mock Context as the second argument.
"""
@pytest.mark.anyio
@@ -280,10 +279,6 @@ class TestSaveSqlQueryToolLogic:
)
with (
patch(
"fastmcp.server.dependencies.get_context",
return_value=mock_ctx,
),
patch("superset.db", mock_db_session),
patch("superset.security_manager", mock_sm),
patch("superset.daos.query.SavedQueryDAO", mock_dao),
@@ -294,7 +289,7 @@ class TestSaveSqlQueryToolLogic:
patch("flask.g", mock_g),
patch.object(mod, "event_logger", mock_event_logger),
):
result = await mod.save_sql_query(request)
result = await mod.save_sql_query(request, mock_ctx)
assert result.id == 42
assert result.label == "Revenue Query"
@@ -336,10 +331,6 @@ class TestSaveSqlQueryToolLogic:
)
with (
patch(
"fastmcp.server.dependencies.get_context",
return_value=mock_ctx,
),
patch("superset.db", mock_db_session),
patch("flask.g", mock_g),
patch.object(mod, "event_logger", mock_event_logger),
@@ -347,7 +338,7 @@ class TestSaveSqlQueryToolLogic:
from superset.exceptions import SupersetErrorException
with pytest.raises(SupersetErrorException, match="not found"):
await mod.save_sql_query(request)
await mod.save_sql_query(request, mock_ctx)
finally:
_restore_modules(saved)
@@ -385,10 +376,6 @@ class TestSaveSqlQueryToolLogic:
)
with (
patch(
"fastmcp.server.dependencies.get_context",
return_value=mock_ctx,
),
patch("superset.db", mock_db_session),
patch("superset.security_manager", mock_sm),
patch("flask.g", mock_g),
@@ -397,7 +384,7 @@ class TestSaveSqlQueryToolLogic:
from superset.exceptions import SupersetSecurityException
with pytest.raises(SupersetSecurityException, match="Access denied"):
await mod.save_sql_query(request)
await mod.save_sql_query(request, mock_ctx)
finally:
_restore_modules(saved)
@@ -449,10 +436,6 @@ class TestSaveSqlQueryToolLogic:
)
with (
patch(
"fastmcp.server.dependencies.get_context",
return_value=mock_ctx,
),
patch("superset.db", mock_db_session),
patch("superset.security_manager", mock_sm),
patch("superset.daos.query.SavedQueryDAO", mock_dao),
@@ -463,7 +446,7 @@ class TestSaveSqlQueryToolLogic:
patch("flask.g", mock_g),
patch.object(mod, "event_logger", mock_event_logger),
):
result = await mod.save_sql_query(request)
result = await mod.save_sql_query(request, mock_ctx)
assert result.id == 10
call_attrs = mock_dao.create.call_args[1]["attributes"]