QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-07 18:35:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(alert/report): bulk select mode should be deactivated (#12977)

Browse Source 
* close bulk delete when switch between alert and report

* update test for alert/report list
This commit is contained in:
Lily Kuang
2021-02-17 09:45:00 -08:00
committed by GitHub
parent 6e09156598
commit e1bb7f4364
3 changed files with 49 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
superset-frontend/spec/javascripts/views/CRUD/alert/AlertList_spec.jsx
View File

@@ -83,15 +83,23 @@ fetchMock.put(alertsEndpoint, { ...mockalerts[0], active: false });
fetchMock.delete(alertEndpoint, {});
fetchMock.delete(alertsEndpoint, {});
describe('AlertList', () => {
const wrapper = mount(
async function mountAndWait(props = {}) {
const mounted = mount(
<Provider store={store}>
<AlertList store={store} user={mockUser} />
<AlertList store={store} user={mockUser} {...props} />
</Provider>,
);
await waitForComponentToPaint(mounted);
return mounted;
}
describe('AlertList', () => {
let wrapper;
beforeAll(async () => {
await waitForComponentToPaint(wrapper);
wrapper = await mountAndWait();
});
it('renders', async () => {
@@ -147,4 +155,30 @@ describe('AlertList', () => {
mockalerts.length + 1, // 1 for each row and 1 for select all
);
});
it('hides bulk actions when switch between alert and report list', async () => {
expect(wrapper.find(IndeterminateCheckbox)).toHaveLength(
mockalerts.length + 1,
);
expect(wrapper.find('[data-test="alert-list"]').hasClass('active')).toBe(
true,
);
expect(wrapper.find('[data-test="report-list"]').hasClass('active')).toBe(
false,
);
const reportWrapper = await mountAndWait({ isReportEnabled: true });
expect(fetchMock.calls(/report\/\?q/)[2][0]).toMatchInlineSnapshot(
`"http://localhost/api/v1/report/?q=(filters:!((col:type,opr:eq,value:Report)),order_column:name,order_direction:desc,page:0,page_size:25)"`,
);
expect(
reportWrapper.find('[data-test="report-list"]').hasClass('active'),
).toBe(true);
expect(
reportWrapper.find('[data-test="alert-list"]').hasClass('active'),
).toBe(false);
expect(reportWrapper.find(IndeterminateCheckbox)).toHaveLength(0);
});
});