mirror of
https://github.com/apache/superset.git
synced 2026-05-12 19:35:17 +00:00
fix: Select options overflowing Save chart modal on Explore view (#12522)
* Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
This commit is contained in:
committed by
GitHub
parent
8f940aecca
commit
e1eeeebe53
@@ -19,7 +19,7 @@
|
||||
/* eslint camelcase: 0 */
|
||||
import React from 'react';
|
||||
import { Alert, FormControl, FormGroup, Radio } from 'react-bootstrap';
|
||||
import { JsonObject, t } from '@superset-ui/core';
|
||||
import { JsonObject, t, styled } from '@superset-ui/core';
|
||||
import ReactMarkdown from 'react-markdown';
|
||||
import Modal from 'src/common/components/Modal';
|
||||
import Button from 'src/components/Button';
|
||||
@@ -55,6 +55,12 @@ type SaveModalState = {
|
||||
action: ActionType;
|
||||
};
|
||||
|
||||
export const StyledModal = styled(Modal)`
|
||||
.ant-modal-body {
|
||||
overflow: visible;
|
||||
}
|
||||
`;
|
||||
|
||||
class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
|
||||
constructor(props: SaveModalProps) {
|
||||
super(props);
|
||||
@@ -153,7 +159,7 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
|
||||
|
||||
render() {
|
||||
return (
|
||||
<Modal
|
||||
<StyledModal
|
||||
show
|
||||
onHide={this.props.onHide}
|
||||
title={t('Save Chart')}
|
||||
@@ -261,7 +267,7 @@ class SaveModal extends React.Component<SaveModalProps, SaveModalState> {
|
||||
/>
|
||||
</FormGroup>
|
||||
</div>
|
||||
</Modal>
|
||||
</StyledModal>
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user