QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 08:04:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: refactor all get_sqla_engine to use contextmanager in codebase (#21943)

Browse Source
This commit is contained in:
Hugh A. Miles II
2022-11-15 13:45:14 -05:00
committed by GitHub
parent 06f87e1467
commit e23efefc46
41 changed files with 635 additions and 595 deletions
Download Patch File Download Diff File Expand all files Collapse all files

36
superset/utils/mock_data.py
View File

@@ -187,29 +187,29 @@ def add_data(
database = get_example_database()
table_exists = database.has_table_by_name(table_name)
engine = database.get_sqla_engine()
if columns is None:
if not table_exists:
raise Exception(
f"The table {table_name} does not exist. To create it you need to "
"pass a list of column names and types."
)
with database.get_sqla_engine_with_context() as engine:
if columns is None:
if not table_exists:
raise Exception(
f"The table {table_name} does not exist. To create it you need to "
"pass a list of column names and types."
)
inspector = inspect(engine)
columns = inspector.get_columns(table_name)
inspector = inspect(engine)
columns = inspector.get_columns(table_name)
# create table if needed
column_objects = get_column_objects(columns)
metadata = MetaData()
table = Table(table_name, metadata, *column_objects)
metadata.create_all(engine)
# create table if needed
column_objects = get_column_objects(columns)
metadata = MetaData()
table = Table(table_name, metadata, *column_objects)
metadata.create_all(engine)
if not append:
engine.execute(table.delete())
if not append:
engine.execute(table.delete())
data = generate_data(columns, num_rows)
engine.execute(table.insert(), data)
data = generate_data(columns, num_rows)
engine.execute(table.insert(), data)
def get_column_objects(columns: List[ColumnInfo]) -> List[Column]: