Re-enable rule line-between-class-members (#10862)

superset-frontend/src/explore/components/Control.jsx

@@ -68,12 +68,15 @@ export default class Control extends React.PureComponent {
     this.onMouseEnter = this.setHover.bind(this, true);
     this.onMouseLeave = this.setHover.bind(this, false);
   }
+
   onChange(value, errors) {
     this.props.actions.setControlValue(this.props.name, value, errors);
   }
+
   setHover(hovered) {
     this.setState({ hovered });
   }
+
   render() {
     const { type, hidden } = this.props;
     if (!type) return null;

superset-frontend/src/explore/components/ControlHeader.jsx

@@ -75,6 +75,7 @@ export default class ControlHeader extends React.Component {
     }
     return null;
   }
+
   render() {
     if (!this.props.label) {
       return null;

superset-frontend/src/explore/components/ControlPanelSection.jsx

@@ -42,9 +42,11 @@ export default class ControlPanelSection extends React.Component {
     this.state = { expanded: this.props.startExpanded };
     this.toggleExpand = this.toggleExpand.bind(this);
   }
+
   toggleExpand() {
     this.setState({ expanded: !this.state.expanded });
   }
+
   renderHeader() {
     const { label, description, hasErrors } = this.props;
     return (

superset-frontend/src/explore/components/DisplayQueryButton.jsx

@@ -90,6 +90,7 @@ export class DisplayQueryButton extends React.PureComponent {
     this.openPropertiesModal = this.openPropertiesModal.bind(this);
     this.closePropertiesModal = this.closePropertiesModal.bind(this);
   }
+
   beforeOpen(resultType) {
     this.setState({ isLoading: true });
 
@@ -118,18 +119,23 @@ export class DisplayQueryButton extends React.PureComponent {
         });
       });
   }
+
   changeFilterText(event) {
     this.setState({ filterText: event.target.value });
   }
+
   redirectSQLLab() {
     this.props.onOpenInEditor(this.props.latestQueryFormData);
   }
+
   openPropertiesModal() {
     this.setState({ isPropertiesModalOpen: true });
   }
+
   closePropertiesModal() {
     this.setState({ isPropertiesModalOpen: false });
   }
+
   renderQueryModalBody() {
     if (this.state.isLoading) {
       return <Loading />;
@@ -157,6 +163,7 @@ export class DisplayQueryButton extends React.PureComponent {
     }
     return null;
   }
+
   renderResultsModalBody() {
     if (this.state.isLoading) {
       return <Loading />;
@@ -172,6 +179,7 @@ export class DisplayQueryButton extends React.PureComponent {
     }
     return null;
   }
+
   renderDataTable(data) {
     return (
       <div style={{ overflow: 'auto' }}>
@@ -213,6 +221,7 @@ export class DisplayQueryButton extends React.PureComponent {
       </div>
     );
   }
+
   renderSamplesModalBody() {
     if (this.state.isLoading) {
       return <Loading />;
@@ -225,6 +234,7 @@ export class DisplayQueryButton extends React.PureComponent {
     }
     return null;
   }
+
   render() {
     const { animation, chartHeight, slice } = this.props;
     return (

superset-frontend/src/explore/components/EmbedCodeButton.jsx

@@ -144,6 +144,7 @@ export default class EmbedCodeButton extends React.Component {
       </Popover>
     );
   }
+
   render() {
     return (
       <OverlayTrigger

superset-frontend/src/explore/components/ExploreViewContainer.jsx

@@ -283,12 +283,14 @@ class ExploreViewContainer extends React.Component {
   toggleModal() {
     this.setState({ showModal: !this.state.showModal });
   }
+
   hasErrors() {
     const ctrls = this.props.controls;
     return Object.keys(ctrls).some(
       k => ctrls[k].validationErrors && ctrls[k].validationErrors.length > 0,
     );
   }
+
   renderErrorMessage() {
     // Returns an error message as a node if any errors are in the store
     const errors = [];
@@ -311,6 +313,7 @@ class ExploreViewContainer extends React.Component {
     }
     return errorMessage;
   }
+
   renderChartContainer() {
     return (
       <ExploreChartPanel

superset-frontend/src/explore/components/SaveModal.jsx

@@ -55,6 +55,7 @@ class SaveModal extends React.Component {
     this.onDashboardSelectChange = this.onDashboardSelectChange.bind(this);
     this.onSliceNameChange = this.onSliceNameChange.bind(this);
   }
+
   componentDidMount() {
     this.props.actions.fetchDashboards(this.props.userId).then(() => {
       const dashboardIds = this.props.dashboards.map(
@@ -72,18 +73,22 @@ class SaveModal extends React.Component {
       }
     });
   }
+
   onSliceNameChange(event) {
     this.setState({ newSliceName: event.target.value });
   }
+
   onDashboardSelectChange(event) {
     const newDashboardName = event ? event.label : null;
     const saveToDashboardId =
       event && typeof event.value === 'number' ? event.value : null;
     this.setState({ saveToDashboardId, newDashboardName });
   }
+
   changeAction(action) {
     this.setState({ action });
   }
+
   saveOrOverwrite(gotodash) {
     this.setState({ alert: null });
     this.props.actions.removeSaveModalAlert();
@@ -117,12 +122,14 @@ class SaveModal extends React.Component {
       });
     this.props.onHide();
   }
+
   removeAlert() {
     if (this.props.alert) {
       this.props.actions.removeSaveModalAlert();
     }
     this.setState({ alert: null });
   }
+
   render() {
     return (
       <Modal show onHide={this.props.onHide}>

superset-frontend/src/explore/components/controls/BoundsControl.jsx

@@ -45,6 +45,7 @@ export default class BoundsControl extends React.Component {
     this.onMinChange = this.onMinChange.bind(this);
     this.onMaxChange = this.onMaxChange.bind(this);
   }
+
   onMinChange(event) {
     this.setState(
       {
@@ -53,6 +54,7 @@ export default class BoundsControl extends React.Component {
       this.onChange,
     );
   }
+
   onMaxChange(event) {
     this.setState(
       {
@@ -61,6 +63,7 @@ export default class BoundsControl extends React.Component {
       this.onChange,
     );
   }
+
   onChange() {
     const mm = this.state.minMax;
     const errors = [];
@@ -76,6 +79,7 @@ export default class BoundsControl extends React.Component {
       this.props.onChange([null, null], errors);
     }
   }
+
   render() {
     return (
       <div>

superset-frontend/src/explore/components/controls/CheckboxControl.jsx

@@ -38,6 +38,7 @@ export default class CheckboxControl extends React.Component {
   onChange() {
     this.props.onChange(!this.props.value);
   }
+
   renderCheckbox() {
     return (
       <Checkbox
@@ -47,6 +48,7 @@ export default class CheckboxControl extends React.Component {
       />
     );
   }
+
   render() {
     if (this.props.label) {
       return (

superset-frontend/src/explore/components/controls/CollectionControl.jsx

@@ -68,19 +68,24 @@ export default class CollectionControl extends React.Component {
     super(props);
     this.onAdd = this.onAdd.bind(this);
   }
+
   onChange(i, value) {
     Object.assign(this.props.value[i], value);
     this.props.onChange(this.props.value);
   }
+
   onAdd() {
     this.props.onChange(this.props.value.concat([this.props.itemGenerator()]));
   }
+
   onSortEnd({ oldIndex, newIndex }) {
     this.props.onChange(arrayMove(this.props.value, oldIndex, newIndex));
   }
+
   removeItem(i) {
     this.props.onChange(this.props.value.filter((o, ix) => i !== ix));
   }
+
   renderList() {
     if (this.props.value.length === 0) {
       return <div className="text-muted">{this.props.placeholder}</div>;
@@ -126,6 +131,7 @@ export default class CollectionControl extends React.Component {
       </SortableListGroup>
     );
   }
+
   render() {
     return (
       <div className="CollectionControl">

superset-frontend/src/explore/components/controls/ColorPickerControl.jsx

@@ -69,9 +69,11 @@ export default class ColorPickerControl extends React.Component {
     super(props);
     this.onChange = this.onChange.bind(this);
   }
+
   onChange(col) {
     this.props.onChange(col.rgb);
   }
+
   renderPopover() {
     const presetColors = getCategoricalSchemeRegistry()
       .get()
@@ -86,6 +88,7 @@ export default class ColorPickerControl extends React.Component {
       </Popover>
     );
   }
+
   render() {
     const c = this.props.value || { r: 0, g: 0, b: 0, a: 0 };
     const colStyle = {

superset-frontend/src/explore/components/controls/DateFilterControl.jsx

@@ -238,11 +238,13 @@ class DateFilterControl extends React.Component {
   componentWillUnmount() {
     document.removeEventListener('click', this.handleClick);
   }
+
   onEnter(event) {
     if (event.key === 'Enter') {
       this.close();
     }
   }
+
   setCustomRange(key, value) {
     const updatedState = { ...this.state, [key]: value };
     const combinedValue = [
@@ -252,6 +254,7 @@ class DateFilterControl extends React.Component {
     ].join(' ');
     this.setState(getStateFromCustomRange(combinedValue));
   }
+
   setCustomStartEnd(key, value) {
     const closeCalendar =
       (key === 'since' && this.state.sinceViewMode === 'days') ||
@@ -265,9 +268,11 @@ class DateFilterControl extends React.Component {
       untilViewMode: closeCalendar ? 'days' : this.state.untilViewMode,
     });
   }
+
   setTypeCustomRange() {
     this.setState({ type: TYPES.CUSTOM_RANGE });
   }
+
   setTypeCustomStartEnd() {
     this.setState({ type: TYPES.CUSTOM_START_END });
   }
@@ -325,18 +330,21 @@ class DateFilterControl extends React.Component {
     this.refs.trigger.hide();
     this.setState({ showSinceCalendar: false, showUntilCalendar: false });
   }
+
   isValidSince(date) {
     return (
       !isValidMoment(this.state.until) ||
       date <= moment(this.state.until, MOMENT_FORMAT)
     );
   }
+
   isValidUntil(date) {
     return (
       !isValidMoment(this.state.since) ||
       date >= moment(this.state.since, MOMENT_FORMAT)
     );
   }
+
   toggleCalendar(key) {
     const nextState = {};
     if (key === 'showSinceCalendar') {
@@ -352,6 +360,7 @@ class DateFilterControl extends React.Component {
     }
     this.setState(nextState);
   }
+
   renderInput(props, key) {
     return (
       <FormGroup>
@@ -372,6 +381,7 @@ class DateFilterControl extends React.Component {
       </FormGroup>
     );
   }
+
   renderPopover() {
     const grainOptions = TIME_GRAIN_OPTIONS.map(grain => (
       <MenuItem
@@ -575,6 +585,7 @@ class DateFilterControl extends React.Component {
       </Popover>
     );
   }
+
   render() {
     const timeRange = this.props.value || defaultProps.value;
     return (

superset-frontend/src/explore/components/controls/FilterBoxItemControl.jsx

@@ -95,9 +95,11 @@ export default class FilterBoxItemControl extends React.Component {
     this.onChange = this.onChange.bind(this);
     this.onControlChange = this.onControlChange.bind(this);
   }
+
   onChange() {
     this.props.onChange(this.state);
   }
+
   onControlChange(attr, value) {
     let typedValue = value;
     const { column: selectedColumnName, multiple } = this.state;
@@ -122,10 +124,13 @@ export default class FilterBoxItemControl extends React.Component {
     }
     this.setState({ [attr]: typedValue }, this.onChange);
   }
+
   setType() {}
+
   textSummary() {
     return this.state.column || 'N/A';
   }
+
   renderForm() {
     return (
       <div>
@@ -257,6 +262,7 @@ export default class FilterBoxItemControl extends React.Component {
       </div>
     );
   }
+
   renderPopover() {
     return (
       <Popover id="ts-col-popo" title={t('Filter Configuration')}>
@@ -264,6 +270,7 @@ export default class FilterBoxItemControl extends React.Component {
       </Popover>
     );
   }
+
   render() {
     return (
       <span>

superset-frontend/src/explore/components/controls/FixedOrMetricControl.jsx

@@ -66,6 +66,7 @@ export default class FixedOrMetricControl extends React.Component {
       metricValue: type === controlTypes.metric ? value : null,
     };
   }
+
   onChange() {
     this.props.onChange({
       type: this.state.type,
@@ -75,12 +76,15 @@ export default class FixedOrMetricControl extends React.Component {
           : this.state.metricValue,
     });
   }
+
   setType(type) {
     this.setState({ type }, this.onChange);
   }
+
   setFixedValue(fixedValue) {
     this.setState({ fixedValue }, this.onChange);
   }
+
   setMetric(metricValue) {
     this.setState({ metricValue }, this.onChange);
   }

superset-frontend/src/explore/components/controls/SpatialControl.jsx

@@ -70,9 +70,11 @@ export default class SpatialControl extends React.Component {
     this.onChange = this.onChange.bind(this);
     this.renderReverseCheckbox = this.renderReverseCheckbox.bind(this);
   }
+
   componentDidMount() {
     this.onChange();
   }
+
   onChange() {
     const { type } = this.state;
     const value = { type };
@@ -101,18 +103,22 @@ export default class SpatialControl extends React.Component {
     this.setState({ value, errors });
     this.props.onChange(value, errors);
   }
+
   setType(type) {
     this.setState({ type }, this.onChange);
   }
+
   close() {
     this.refs.trigger.hide();
   }
+
   toggleCheckbox() {
     this.setState(
       { reverseCheckbox: !this.state.reverseCheckbox },
       this.onChange,
     );
   }
+
   renderLabelContent() {
     if (this.state.errors.length > 0) {
       return 'N/A';
@@ -128,6 +134,7 @@ export default class SpatialControl extends React.Component {
     }
     return null;
   }
+
   renderSelect(name, type) {
     return (
       <SelectControl
@@ -144,6 +151,7 @@ export default class SpatialControl extends React.Component {
       />
     );
   }
+
   renderReverseCheckbox() {
     return (
       <span>
@@ -155,6 +163,7 @@ export default class SpatialControl extends React.Component {
       </span>
     );
   }
+
   renderPopover() {
     return (
       <Popover id="filter-popover">
@@ -219,6 +228,7 @@ export default class SpatialControl extends React.Component {
       </Popover>
     );
   }
+
   render() {
     return (
       <div>

superset-frontend/src/explore/components/controls/TextAreaControl.jsx

@@ -68,9 +68,11 @@ export default class TextAreaControl extends React.Component {
   onControlChange(event) {
     this.props.onChange(event.target.value);
   }
+
   onAceChange(value) {
     this.props.onChange(value);
   }
+
   renderEditor(inModal = false) {
     const value = this.props.value || '';
     if (this.props.language) {
@@ -103,6 +105,7 @@ export default class TextAreaControl extends React.Component {
       </FormGroup>
     );
   }
+
   renderModalBody() {
     return (
       <div>
@@ -111,6 +114,7 @@ export default class TextAreaControl extends React.Component {
       </div>
     );
   }
+
   render() {
     const controlHeader = <ControlHeader {...this.props} />;
     return (

superset-frontend/src/explore/components/controls/TextControl.tsx

@@ -36,6 +36,7 @@ export default class TextControl extends React.Component<TextControlProps> {
     super(props);
     this.onChange = this.onChange.bind(this);
   }
+
   onChange(event: any) {
     let { value } = event.target;
 
@@ -59,6 +60,7 @@ export default class TextControl extends React.Component<TextControlProps> {
     }
     this.props.onChange(value, errors);
   }
+
   render() {
     const { value: rawValue } = this.props;
     const value =

superset-frontend/src/explore/components/controls/TimeSeriesColumnControl.jsx

@@ -102,29 +102,39 @@ export default class TimeSeriesColumnControl extends React.Component {
     this.state = state;
     this.onChange = this.onChange.bind(this);
   }
+
   onChange() {
     this.props.onChange(this.state);
   }
+
   onSelectChange(attr, opt) {
     this.setState({ [attr]: opt.value }, this.onChange);
   }
+
   onTextInputChange(attr, event) {
     this.setState({ [attr]: event.target.value }, this.onChange);
   }
+
   onCheckboxChange(attr, value) {
     this.setState({ [attr]: value }, this.onChange);
   }
+
   onBoundsChange(bounds) {
     this.setState({ bounds }, this.onChange);
   }
+
   onYAxisBoundsChange(yAxisBounds) {
     this.setState({ yAxisBounds }, this.onChange);
   }
+
   setType() {}
+
   textSummary() {
     return `${this.state.label}`;
   }
+
   edit() {}
+
   formRow(label, tooltip, ttLabel, control) {
     return (
       <Row style={{ marginTop: '5px' }}>
@@ -140,6 +150,7 @@ export default class TimeSeriesColumnControl extends React.Component {
       </Row>
     );
   }
+
   renderPopover() {
     return (
       <Popover id="ts-col-popo" title="Column Configuration">
@@ -297,6 +308,7 @@ export default class TimeSeriesColumnControl extends React.Component {
       </Popover>
     );
   }
+
   render() {
     return (
       <span>

superset-frontend/src/explore/components/controls/ViewportControl.jsx

@@ -60,12 +60,14 @@ export default class ViewportControl extends React.Component {
     super(props);
     this.onChange = this.onChange.bind(this);
   }
+
   onChange(ctrl, value) {
     this.props.onChange({
       ...this.props.value,
       [ctrl]: value,
     });
   }
+
   renderTextControl(ctrl) {
     return (
       <div key={ctrl}>
@@ -78,6 +80,7 @@ export default class ViewportControl extends React.Component {
       </div>
     );
   }
+
   renderPopover() {
     return (
       <Popover id={`filter-popover-${this.props.name}`} title="Viewport">
@@ -85,6 +88,7 @@ export default class ViewportControl extends React.Component {
       </Popover>
     );
   }
+
   renderLabel() {
     if (this.props.value.longitude && this.props.value.latitude) {
       return `${decimal2sexagesimal(
@@ -93,6 +97,7 @@ export default class ViewportControl extends React.Component {
     }
     return 'N/A';
   }
+
   render() {
     return (
       <div>