feat(Explore): add sort to edit dataset modal (#14872)

* inital commit

* refac

* fix ui issues and sort

* fix lint

* add suggestions

* lint

* add suggestions

* add enum

* add enum to inter
This commit is contained in:
Phillip Kelley-Dotson
2021-06-14 15:20:22 -07:00
committed by GitHub
parent 7a21f9afa7
commit e2abf59534
2 changed files with 99 additions and 8 deletions

View File

@@ -141,6 +141,7 @@ function ColumnCollectionTable({
<CollectionTable
collection={columns}
tableColumns={['column_name', 'type', 'is_dttm', 'filterable', 'groupby']}
sortColumns={['column_name', 'type', 'is_dttm', 'filterable', 'groupby']}
allowDeletes
allowAddItem={allowAddItem}
itemGenerator={itemGenerator}
@@ -881,6 +882,7 @@ class DatasourceEditor extends React.PureComponent {
return (
<CollectionTable
tableColumns={['metric_name', 'verbose_name', 'expression']}
sortColumns={['metric_name', 'verbose_name', 'expression']}
columnLabels={{
metric_name: t('Metric'),
verbose_name: t('Label'),