QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-18 07:35:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(presto,trino): use correct literal dttm separator (#20123)

Browse Source 
* fix(presto,trino): use correct literal dttm separator

* remove redundant tests
This commit is contained in:
Ville Brofeldt
2022-05-19 20:42:31 +03:00
committed by GitHub
parent d5c5e58583
commit e2f11d3680
6 changed files with 8 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/integration_tests/db_engine_specs/presto_tests.py
View File

@@ -512,19 +512,6 @@ class TestPrestoDbEngineSpec(TestDbEngineSpec):
query_result = str(result.compile(compile_kwargs={"literal_binds": True}))
self.assertEqual("SELECT \nWHERE ds = '01-01-19' AND hour = 1", query_result)
def test_convert_dttm(self):
dttm = self.get_dttm()
self.assertEqual(
PrestoEngineSpec.convert_dttm("DATE", dttm),
"DATE '2019-01-02'",
)
self.assertEqual(
PrestoEngineSpec.convert_dttm("TIMESTAMP", dttm),
"TIMESTAMP '2019-01-02T03:04:05.678900'",
)
def test_query_cost_formatter(self):
raw_cost = [
{

13
tests/integration_tests/db_engine_specs/trino_tests.py
View File

@@ -27,19 +27,6 @@ from tests.integration_tests.db_engine_specs.base_tests import TestDbEngineSpec
class TestTrinoDbEngineSpec(TestDbEngineSpec):
def test_convert_dttm(self):
dttm = self.get_dttm()
self.assertEqual(
TrinoEngineSpec.convert_dttm("DATE", dttm),
"DATE '2019-01-02'",
)
self.assertEqual(
TrinoEngineSpec.convert_dttm("TIMESTAMP", dttm),
"TIMESTAMP '2019-01-02T03:04:05.678900'",
)
def test_adjust_database_uri(self):
url = URL(drivername="trino", database="hive")
TrinoEngineSpec.adjust_database_uri(url, selected_schema="foobar")