mirror of
https://github.com/apache/superset.git
synced 2026-05-12 19:35:17 +00:00
fix: implement native browser fullscreen for dashboard charts (#38819)
Signed-off-by: Venkateshwaran Shanmugham <venkateshwaracholan@gmail.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Mehmet Salih Yavuz <salih.yavuz@proton.me> Co-authored-by: Richard Fogaça <richardfogaca@gmail.com> Co-authored-by: Richard Fogaca Nienkotter <63572350+richardfogaca@users.noreply.github.com>
This commit is contained in:
committed by
GitHub
parent
680cef0ee0
commit
e39dd1afce
@@ -273,9 +273,7 @@ function Echart(
|
||||
);
|
||||
|
||||
const notMerge = !isDashboardRefreshing;
|
||||
if (!notMerge) {
|
||||
chartRef.current?.dispatchAction({ type: 'hideTip' });
|
||||
}
|
||||
chartRef.current?.dispatchAction({ type: 'hideTip' });
|
||||
chartRef.current?.setOption(themedEchartOptions, {
|
||||
notMerge,
|
||||
replaceMerge: notMerge ? undefined : ['series'],
|
||||
|
||||
@@ -29,7 +29,8 @@ import { Refs } from '../types';
|
||||
|
||||
export function getDefaultTooltip(refs: Refs) {
|
||||
return {
|
||||
appendToBody: true,
|
||||
appendToBody:
|
||||
typeof document !== 'undefined' ? !document.fullscreenElement : true,
|
||||
borderColor: 'transparent',
|
||||
// CSS hack applied on this class to resolve https://github.com/apache/superset/issues/30058
|
||||
className: 'echarts-tooltip',
|
||||
|
||||
Reference in New Issue
Block a user