QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-06-01 05:39:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(owners): display email in owner selectors (#37906)

Browse Source
This commit is contained in:
Michael S. Molina
2026-02-13 09:01:05 -03:00
committed by GitHub
parent 0c0d915391
commit e3e2bece6b
25 changed files with 407 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

50
superset-frontend/src/explore/components/PropertiesModal/index.tsx
View File

@@ -37,6 +37,12 @@ import {
import Chart, { Slice } from 'src/types/Chart';
import withToasts from 'src/components/MessageToasts/withToasts';
import { type TagType } from 'src/components';
import {
OwnerSelectLabel,
OWNER_TEXT_LABEL_PROP,
OWNER_EMAIL_PROP,
OWNER_OPTION_FILTER_PROPS,
} from 'src/features/owners/OwnerSelectLabel';
import { TagTypeEnum } from 'src/components/Tag/TagType';
import { loadTags } from 'src/components/Tag/utils';
import {
@@ -153,6 +159,7 @@ function PropertiesModal({
'owners.id',
'owners.first_name',
'owners.last_name',
'owners.email',
'tags.id',
'tags.name',
'tags.type',
@@ -164,10 +171,25 @@ function PropertiesModal({
});
const chart = response.json.result;
setSelectedOwners(
chart?.owners?.map((owner: any) => ({
value: owner.id,
label: `${owner.first_name} ${owner.last_name}`,
})),
chart?.owners?.map(
(owner: {
id: number;
first_name: string;
last_name: string;
email?: string;
}) => {
const ownerName = `${owner.first_name} ${owner.last_name}`;
return {
value: owner.id,
label: OwnerSelectLabel({
name: ownerName,
email: owner.email,
}),
[OWNER_TEXT_LABEL_PROP]: ownerName,
[OWNER_EMAIL_PROP]: owner.email ?? '',
};
},
),
);
if (isFeatureEnabled(FeatureFlag.TaggingSystem)) {
const customTags = chart.tags?.filter(
@@ -196,10 +218,21 @@ function PropertiesModal({
}).then(response => ({
data: response.json.result
.filter((item: { extra: { active: boolean } }) => item.extra.active)
.map((item: { value: number; text: string }) => ({
value: item.value,
label: item.text,
})),
.map(
(item: {
value: number;
text: string;
extra: { email?: string };
}) => ({
value: item.value,
label: OwnerSelectLabel({
name: item.text,
email: item.extra?.email,
}),
[OWNER_TEXT_LABEL_PROP]: item.text,
[OWNER_EMAIL_PROP]: item.extra?.email ?? '',
}),
),
totalCount: response.json.count,
}));
},
@@ -372,6 +405,7 @@ function PropertiesModal({
options={loadOptions}
disabled={!selectedOwners}
allowClear
optionFilterProps={OWNER_OPTION_FILTER_PROPS}
/>
</ModalFormField>
{isFeatureEnabled(FeatureFlag.TaggingSystem) && (