QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-21 17:14:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce more ruff rules (#31447)

Browse Source 
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
superset/migrations/shared/security_converge.py
View File

@@ -189,7 +189,7 @@ def _delete_old_permissions(
- Deletes the ViewMenu if it's an orphan now
"""
# Delete old permissions
for old_pvm, new_pvms in pvm_map.items():
for old_pvm, new_pvms in pvm_map.items(): # noqa: B007
old_permission_name = old_pvm.permission.name
old_view_name = old_pvm.view_menu.name
logger.info(f"Going to delete pvm: {old_pvm}")
@@ -212,7 +212,7 @@ def _delete_old_permissions(
session.delete(old_pvm.view_menu)
def migrate_roles(
def migrate_roles( # noqa: C901
session: Session,
pvm_key_map: PvmMigrationMapType,
commit: bool = False,
@@ -252,7 +252,7 @@ def migrate_roles(
def get_reversed_new_pvms(pvm_map: PvmMigrationMapType) -> dict[str, tuple[str, ...]]:
reversed_pvms: dict[str, tuple[str, ...]] = {}
for old_pvm, new_pvms in pvm_map.items():
for old_pvm, new_pvms in pvm_map.items(): # noqa: B007
if old_pvm.view not in reversed_pvms:
reversed_pvms[old_pvm.view] = (old_pvm.permission,)
else: