QT/superset2
1
0
Fork 0
mirror of https://github.com/apache/superset.git synced 2026-04-19 16:14:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: enforce more ruff rules (#31447)

Browse Source 
Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>
This commit is contained in:
Maxime Beauchemin
2024-12-18 17:41:34 -08:00
committed by GitHub
parent 9da65d6bfd
commit e51b95ffa8
375 changed files with 1821 additions and 1718 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
tests/integration_tests/queries/api_tests.py
View File

@@ -76,7 +76,7 @@ class TestQueryApi(SupersetTestCase):
db.session.commit()
return query
@pytest.fixture()
@pytest.fixture
def create_queries(self):
with self.create_app().app_context():
queries = []
@@ -90,7 +90,7 @@ class TestQueryApi(SupersetTestCase):
example_database_id,
admin_id,
self.get_random_string(),
sql=f"SELECT col1, col2 from table{cx}",
sql=f"SELECT col1, col2 from table{cx}", # noqa: S608
rows=cx,
status=QueryStatus.SUCCESS
if (cx % 2) == 0
@@ -102,7 +102,7 @@ class TestQueryApi(SupersetTestCase):
main_database_id,
alpha_id,
self.get_random_string(),
sql=f"SELECT col1, col2 from table{QUERIES_FIXTURE_COUNT}",
sql=f"SELECT col1, col2 from table{QUERIES_FIXTURE_COUNT}", # noqa: S608
rows=QUERIES_FIXTURE_COUNT,
status=QueryStatus.SUCCESS,
)
@@ -118,7 +118,7 @@ class TestQueryApi(SupersetTestCase):
@staticmethod
def get_random_string(length: int = 10):
letters = string.ascii_letters
return "".join(random.choice(letters) for i in range(length))
return "".join(random.choice(letters) for i in range(length)) # noqa: S311
def test_get_query(self):
"""
@@ -219,7 +219,7 @@ class TestQueryApi(SupersetTestCase):
)
# Gamma1 user, only sees their own queries
self.login(username="gamma_1", password="password")
self.login(username="gamma_1", password="password") # noqa: S106
uri = f"api/v1/query/{query_gamma2.id}"
rv = self.client.get(uri)
assert rv.status_code == 404
@@ -229,7 +229,7 @@ class TestQueryApi(SupersetTestCase):
# Gamma2 user, only sees their own queries
self.logout()
self.login(username="gamma_2", password="password")
self.login(username="gamma_2", password="password") # noqa: S106
uri = f"api/v1/query/{query_gamma1.id}"
rv = self.client.get(uri)
assert rv.status_code == 404
@@ -266,7 +266,7 @@ class TestQueryApi(SupersetTestCase):
data = json.loads(rv.data.decode("utf-8"))
assert data["count"] == QUERIES_FIXTURE_COUNT
# check expected columns
assert sorted(list(data["result"][0].keys())) == [
assert sorted(list(data["result"][0].keys())) == [ # noqa: C414
"changed_on",
"database",
"end_time",
@@ -283,7 +283,7 @@ class TestQueryApi(SupersetTestCase):
"tracking_url",
"user",
]
assert sorted(list(data["result"][0]["user"].keys())) == [
assert sorted(list(data["result"][0]["user"].keys())) == [ # noqa: C414
"first_name",
"id",
"last_name",
@@ -431,7 +431,7 @@ class TestQueryApi(SupersetTestCase):
self.login(ADMIN_USERNAME)
timestamp = datetime.timestamp(now - timedelta(days=2)) * 1000
uri = f"api/v1/query/updated_since?q={prison.dumps({'last_updated_ms': timestamp})}"
uri = f"api/v1/query/updated_since?q={prison.dumps({'last_updated_ms': timestamp})}" # noqa: E501
rv = self.client.get(uri)
assert rv.status_code == 200

6
tests/integration_tests/queries/saved_queries/api_tests.py
View File

@@ -92,7 +92,7 @@ class TestSavedQueryApi(SupersetTestCase):
description="cool description",
)
@pytest.fixture()
@pytest.fixture
def create_saved_queries(self):
with self.create_app().app_context():
saved_queries = []
@@ -480,9 +480,9 @@ class TestSavedQueryApi(SupersetTestCase):
assert data_by_id["count"] == data_by_name["count"], len(
expected_saved_queries
)
assert set(query["id"] for query in data_by_id["result"]) == set(
assert set(query["id"] for query in data_by_id["result"]) == set( # noqa: C401
query["id"] for query in data_by_name["result"]
), set(query.id for query in expected_saved_queries)
), set(query.id for query in expected_saved_queries) # noqa: C401
@pytest.mark.usefixtures("create_saved_queries")
def test_get_saved_query_favorite_filter(self):

8
tests/integration_tests/queries/saved_queries/commands_tests.py
View File

@@ -47,7 +47,7 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
sql="SELECT 42",
label="The answer",
schema="schema1",
description="Answer to the Ultimate Question of Life, the Universe, and Everything",
description="Answer to the Ultimate Question of Life, the Universe, and Everything", # noqa: E501
)
db.session.add(self.example_query)
db.session.commit()
@@ -78,7 +78,7 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
"catalog": None,
"schema": "schema1",
"label": "The answer",
"description": "Answer to the Ultimate Question of Life, the Universe, and Everything",
"description": "Answer to the Ultimate Question of Life, the Universe, and Everything", # noqa: E501
"sql": "SELECT 42",
"uuid": str(self.example_query.uuid),
"version": "1.0.0",
@@ -110,7 +110,7 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
command = ExportSavedQueriesCommand([self.example_query.id])
contents = command.run()
with self.assertRaises(SavedQueryNotFoundError):
with self.assertRaises(SavedQueryNotFoundError): # noqa: PT027
next(contents)
@patch("superset.queries.saved_queries.filters.g")
@@ -120,7 +120,7 @@ class TestExportSavedQueriesCommand(SupersetTestCase):
command = ExportSavedQueriesCommand([-1])
contents = command.run()
with self.assertRaises(SavedQueryNotFoundError):
with self.assertRaises(SavedQueryNotFoundError): # noqa: PT027
next(contents)
@patch("superset.queries.saved_queries.filters.g")